Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework badge counting #15

Open
Rayquaza01 opened this issue Nov 6, 2018 · 0 comments
Open

Rework badge counting #15

Rayquaza01 opened this issue Nov 6, 2018 · 0 comments

Comments

@Rayquaza01
Copy link
Owner

A user, Firefox user 57a3e1, has rated your addon, note-taker.

Rating: 4/5

You can view the rating here: 
https://addons.mozilla.org/addon/note-taker/reviews/1228372

Review Text:
Very interesting. I could suggest to add a notification badge if there is 
an URL note, so that it is visible (not only if ther is a Domain note)


Currently, badges are counted from the note associated with the first tab of the default display.

This review asks for badges to display even if the current display does not have a note in the first tab or current display.

Examples that don't work now that will be addressed by this:

Display is domain.
No note on domain, note on URL.

Display is domain.
No note on tab 1, note on tab 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant