To-Dos after Zuzalu Passport

[mhchia]

Things should be done after #20 is merged. Sorted by priority.

Cosmetic

• Add flag to indicate "Safari is not stable" if the user is using Safari

Bug fixes

• signal in RLN proof is assigned a random value instead of the hash(message). This allows malicious peer to use the proof with random messages.
  • Solution: change signal to hash(message) and verify the message when receiving the proof
• Document
  • Update README.md
• Browser
  • Safari: user can login and see the chatrooms, but the popup from sending messages is buggy
    • "Error while sending the message. You are either banned from the chat or deleted from InteRep"
    • popup acts strangely
• Configs
  • Even RLN_IDENTIFIER is in configs, but assigning value in the configs does nothing. It should be due to the hardcoded value
• zeroValue is hardcoded at the moment. It should come from Group, or made configurable

Refactor

• Packages
  • Use rln-pcd package from zupass repo instead of the local rln-pcd.ts
  • Use the official packages: previously, I just cloned some packages that was not working with our environment. We should find out the reason why they fail and use the official one
    • test-pcd-semaphore-group-pcd -> semaphore-group-pcd
• Syncer: add generic interfaces for 1) id keepers and 2) membership providers. Make it easier to support new id keepers (Zupass, CryptKeeper, ...etc)
• Ensure popup is called correctly: app/src/util/request-passport-client.ts
• Configs
  • Make SECONDS_PER_EPOCH configurable
    • Originally in
      • client: zk-chat-client-lib/src/chat/index.ts
      • server: zk-chat-server-lib/src/create_server.ts
  • rename INTERREP_V2 to something more generic like "MEMBERSHIP_PROVIDER"
• Use yarn link: when building zk-chat-client-lib from app and zk-chat-server-lib from server
• Deployment
  • Remove the stale docker-compose-prod.yaml
  • Remove unused deployment settings
• Remove debugging console.logs
  • Search console.log with !@#