Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format_row() renders charts unusable #66

Open
JoRSchmidt1995 opened this issue May 31, 2023 · 1 comment
Open

format_row() renders charts unusable #66

JoRSchmidt1995 opened this issue May 31, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@JoRSchmidt1995
Copy link

I use format_row() in my SlickReportViews to make my tables more readable (ie. adding commas between large numbers with django humanize intcomma and having the groupby fields refer to their name field within their respective models, etc.), but this prevents the chart from displaying the labels correctly (in the case of referring to the groupby fields' names instead of IDs) or picking up the data entirely (when formatting numbers with intcomma). Please advise (code below for reference.

image

@RamezIssac
Copy link
Owner

I can see 2 things in the code

  1. row_obj["cusip"] is now holing the model, instead of the .name for example.
    Changing how the group is displayed should NOT affect the charts.

  2. intcomma might be returning a string which might trip off the charts . (i believe especially pie)
    I can suggest that you handle the number format in the front end (maybe via the datatable init)

I will check further nonetheless.

@RamezIssac RamezIssac added the enhancement New feature or request label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants