Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause/stop should ramp #72

Open
Ralith opened this issue Nov 8, 2021 · 2 comments
Open

Pause/stop should ramp #72

Ralith opened this issue Nov 8, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@Ralith
Copy link
Owner

Ralith commented Nov 8, 2021

These probably(?) cause popping as-is.

@Ralith Ralith added the bug Something isn't working label Nov 8, 2021
@mooman219
Copy link
Contributor

I've reproduced it, the code here will need its transition smoothed

oddio/src/mixer.rs

Lines 92 to 98 in adc60db

if signal.is_stopped() {
this.set.remove(i);
continue;
}
if signal.is_paused() {
continue;
}

@Ralith
Copy link
Owner Author

Ralith commented Dec 24, 2021

A special case will be required in SpatialScene to support this for Seek signals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants