Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web template: My Carpools page - carpools in which you are a passenger and in which you are a driver not immediately visually distinguishable #414

Closed
flynnwastaken opened this issue Oct 15, 2017 · 1 comment
Labels
design needed starter Good issue to get warmed up on the codebase web template

Comments

@flynnwastaken
Copy link
Contributor

The "You’re the driver of this carpool. Thanks for driving!" and "You’re confirmed for this carpool. Have a good trip!" banners under rides on the My Carpools page are the same color and look very similar. Carpools appear to be sorted chronologically, rather than by user role (rider or driver), so this visual similarity is confusing and makes it difficult to figure out ride statuses.

Two possible ways to change:

  1. different colored banners for "you're the driver" and "you're confirmed" messages
  2. sort in two sections by whether you are offering the ride or requesting the ride, and chronological within those categories, no change to banner color necessary
@jillh510 jillh510 added enhancement starter Good issue to get warmed up on the codebase labels Jul 10, 2018
@jillh510
Copy link
Contributor

This is a dup of #515, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design needed starter Good issue to get warmed up on the codebase web template
Projects
None yet
Development

No branches or pull requests

2 participants