Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change getMIDI() method as default for single track in all midi and midi compatible files #216

Closed
Raffaello opened this issue Sep 18, 2022 · 0 comments · Fixed by #219
Closed

change getMIDI() method as default for single track in all midi and midi compatible files #216

Raffaello opened this issue Sep 18, 2022 · 0 comments · Fixed by #219
Assignees
@Raffaello
Labels
enhancement New feature or request file I/O file related
Milestone
General Midi Emul...

Comments

@Raffaello
Copy link
Owner

create a getMIDI() interface (default to convertToSingleTrack) and renanme the actual getMIDI in MIDFile (getOriginalMidi() no conversion)
use the getMIDI() interface into MUSFile too as that method is common (it will be in XMI too later on)
@Raffaello Raffaello added enhancement New feature or request file I/O file related labels Sep 18, 2022
@Raffaello Raffaello added this to the General Midi Emulation milestone Sep 18, 2022
@Raffaello Raffaello self-assigned this Sep 18, 2022
@Raffaello Raffaello linked a pull request Sep 19, 2022 that will close this issue
Version 0.6.x #219
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Raffaello Raffaello

Labels
enhancement New feature or request file I/O file related
Projects
Architecture
Status: Done
MIDI
Status: Done
Milestone
General Midi Emulation
Development

Successfully merging a pull request may close this issue.

Version 0.6.x Raffaello/sdl2-hyper-sonic-drivers
1 participant
@Raffaello