From 9b3d22dcf6ed6dee550246198d3eebf776642866 Mon Sep 17 00:00:00 2001 From: Rafael Gonzaga Date: Sat, 10 Aug 2024 17:07:54 -0300 Subject: [PATCH] benchmark: rename count to n It's a common approach to use n as number of iterations over the benchmark. Changing it from count to n will also make ./node benchmark/run.js --set n=X more meaningful among other benchmarks PR-URL: https://github.com/nodejs/node/pull/54271 Reviewed-By: Luigi Pinca Reviewed-By: Trivikram Kamat --- benchmark/misc/startup-cli-version.js | 12 ++++++------ benchmark/misc/startup-core.js | 16 ++++++++-------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/benchmark/misc/startup-cli-version.js b/benchmark/misc/startup-cli-version.js index 85b1daa83c3d11..a553f90621f45d 100644 --- a/benchmark/misc/startup-cli-version.js +++ b/benchmark/misc/startup-cli-version.js @@ -18,12 +18,12 @@ const availableCli = [ ].filter((cli) => existsSync(path.resolve(__dirname, '../../', cli))); const bench = common.createBenchmark(main, { cli: availableCli, - count: [30], + n: [30], }); function spawnProcess(cli, bench, state) { const cmd = process.execPath || process.argv[0]; - while (state.finished < state.count) { + while (state.finished < state.n) { const child = spawnSync(cmd, [cli, '--version'], { env: { npm_config_loglevel: 'silent', ...process.env }, }); @@ -41,15 +41,15 @@ function spawnProcess(cli, bench, state) { bench.start(); } - if (state.finished === state.count) { - bench.end(state.count); + if (state.finished === state.n) { + bench.end(state.n); } } } -function main({ count, cli }) { +function main({ n, cli }) { cli = path.resolve(__dirname, '../../', cli); const warmup = 3; - const state = { count, finished: -warmup }; + const state = { n, finished: -warmup }; spawnProcess(cli, bench, state); } diff --git a/benchmark/misc/startup-core.js b/benchmark/misc/startup-core.js index d16a989fd2ce75..053a1ec0cbff8f 100644 --- a/benchmark/misc/startup-core.js +++ b/benchmark/misc/startup-core.js @@ -12,12 +12,12 @@ const bench = common.createBenchmark(main, { 'test/fixtures/snapshot/typescript', ], mode: ['process', 'worker'], - count: [30], + n: [30], }); function spawnProcess(script, bench, state) { const cmd = process.execPath || process.argv[0]; - while (state.finished < state.count) { + while (state.finished < state.n) { const child = spawnSync(cmd, [script]); if (child.status !== 0) { console.log('---- STDOUT ----'); @@ -32,8 +32,8 @@ function spawnProcess(script, bench, state) { bench.start(); } - if (state.finished === state.count) { - bench.end(state.count); + if (state.finished === state.n) { + bench.end(state.n); } } } @@ -49,18 +49,18 @@ function spawnWorker(script, bench, state) { // Finished warmup. bench.start(); } - if (state.finished < state.count) { + if (state.finished < state.n) { spawnWorker(script, bench, state); } else { - bench.end(state.count); + bench.end(state.n); } }); } -function main({ count, script, mode }) { +function main({ n, script, mode }) { script = path.resolve(__dirname, '../../', `${script}.js`); const warmup = 3; - const state = { count, finished: -warmup }; + const state = { n, finished: -warmup }; if (mode === 'worker') { Worker = require('worker_threads').Worker; spawnWorker(script, bench, state);