Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial implementation of BoilerGeneric and Example #1443
base: main
Are you sure you want to change the base?
initial implementation of BoilerGeneric and Example #1443
Changes from 37 commits
02a7843
0fee6f0
27ca717
94b43d9
3012e81
c5ad040
19cf460
703662b
7c9d7f2
d9683ef
9e50313
418a62c
f7828da
d7b9b00
9fec9b4
2b15b8e
7d58a88
eddc6a7
8fa1284
3a5e0b5
16d0600
937f8f4
b727361
fc1728a
4684156
476dace
bc101de
a653aa5
4b4224e
f1b82a3
0e8cd19
516b3f6
43d000b
a93e9d4
81531f9
7e60a40
21d1785
100b1a5
f02726f
07db990
1f3b095
6c5efc5
ebcd83b
52b7e9d
479ad5a
8fb8bc0
70b9fe0
1dc9550
dbe0265
500141d
735e530
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get the doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
retTem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wont check further naming convention, please adhere to the errors in the .txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use a parameter if it is only the nominal value?
Also, check Arial font
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output is only based on nominal conditions but exists for multiple setups, because
TSup_nominal
andTRet_nominal
are input parameters. As the data is behind the calculation is pre calculated anway, we can also put this data into the .sdf file. Removed the font issues with commit 07db990There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replaceable as usual?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adressed with 07db990