Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of ncDataReader #313

Closed
PMehrfeld opened this issue Dec 7, 2016 · 10 comments
Closed

Integration of ncDataReader #313

PMehrfeld opened this issue Dec 7, 2016 · 10 comments
Assignees

Comments

@PMehrfeld
Copy link
Member

I am currently working on getting an alternative data reader integrated into AixLib since I have faced many issues with CombiTimeTables in the context of complex simulations.
The repo is located here: https://github.com/tbeu/netCDF-DataReader

I will discuss two issues in that repository and report the news here.

@PMehrfeld PMehrfeld self-assigned this Dec 7, 2016
@tbeu
Copy link
Contributor

tbeu commented Dec 8, 2016

Can you please share your issues with the CombiTimeTable. Ist it about mo:#2080?

@thorade
Copy link
Contributor

thorade commented Dec 8, 2016

Feel free to also comment here:
UdK-VPT/BuildingSystems#12
Maybe we could have one very good data reader in Annex60?

@tbeu
Copy link
Contributor

tbeu commented Dec 8, 2016

@thorade Thanks for cross-referencing. I even forgot about it and the ideas mentioned therein.

@PMehrfeld
Copy link
Member Author

I have commented the issue here:
UdK-VPT/BuildingSystems#12

Hopefully, I will have a look at https://trac.modelica.org/Modelica/ticket/2080 next week.

@PMehrfeld
Copy link
Member Author

PMehrfeld commented Feb 1, 2017

@FWuellhorst : Write documentation and migrate NcDataReader model into AixLib
I think AixLib.Utilities.Sources might be a could sub-package

@mlauster
Copy link
Contributor

mlauster commented Feb 6, 2017

Closed via #340

@mlauster mlauster closed this as completed Feb 6, 2017
@PMehrfeld
Copy link
Member Author

With commit 996399f I deleted parameter standard values. But for string vectors varName, attNameReal and attNameInt at least empty strings like {""} are necessary, otherwise error occurs Failed to expand the variable NcDataReader_test.varName.
Since all use_... parameters are true and strings were set in the example, the error did not occur. But with default values an error will be thrown.

@mlauster
Copy link
Contributor

mlauster commented Feb 8, 2017

Closed via #342

@mlauster mlauster closed this as completed Feb 8, 2017
@mlauster
Copy link
Contributor

@PMehrfeld, is our netCDF reader module read-only?
See UdK-VPT/BuildingSystems#64 (comment)
I think that's a valuable point

@PMehrfeld
Copy link
Member Author

Since we are not checking out the repo https://github.com/tbeu/netCDF-DataReader as a submodule of our AixLib repo, there is no further need to concern about read-only rights. Any User must clone the repo and open the Modelica library of the netCDF-DataReader manually. This is also described in the documentation of the particular model in AixLib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants