Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor pressureDrop coefficient to dp_nominal in PartialHeatGenerator #1444

Open
DaJansenGit opened this issue Jun 6, 2023 · 0 comments
Open

Comments

@DaJansenGit
Copy link
Member

What is the problem?

Currently the PartialHeatGenerator model uses the following equation to calculate the dp_nominal variable:

dp_nominal=m_flow_nominal^2*a/(rho_default^2)

with a being the pressureDrop coefficient. As this coefficient is only a relict of the Modelica.Fluid.Fittings.GenericResistances.VolumeFlowRate model which is not used anymore, we want to get rid of it.

How do we want to solve it?

  • Remove the default equation from PartialHeatGenerator
  • Refactor all records as they provide the pressure coefficient currently (but only because it was needed for the former model approach and not because the data sheets provided it).
    • calculation to calculate dp_nominal from a: dp_nominal = m_flow_nominal^2*a/(rho_default^2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant