Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify control argument names #76

Open
jeffkeller87 opened this issue Mar 16, 2016 · 4 comments
Open

Simplify control argument names #76

jeffkeller87 opened this issue Mar 16, 2016 · 4 comments

Comments

@jeffkeller87
Copy link

Control argument names are outdated, occasionally inconsistent, and confusing (particularly the "normal" and "fixed" nomenclature). I've set the HBControl function up to easily catch deprecated arguments and direct users to new usages/names. I don't think this is a pressing issue at all, but wanted to get my thoughts down before I lose them.

Below are my suggestions: currentName (proposedName)

  • gVarNamesNormal (???)
  • gVarNamesFixed (???)
  • gDIST (dist)
  • FC (???)
  • svN (???)
  • gNCREP (???)
  • gNEREP (???)
  • gNSKIP (skip)
  • gINFOSKIP (trace)
  • priorVariance (pv)
  • degreesOfFreedom (df)
  • constraintsNorm (???)
  • rho/rhoF (???)
  • targetAcceptanceNormal (???)
  • targetAcceptanceFixed (???)
  • gFULLCV (???)
  • gStoreDraws (keep.draws)
  • gSeed (seed)
  • gMINCOEF (???)
  • gMAXCOEF (???)
  • nodiagnostics (diagnostics; invert to avoid double negative)
@jeffkeller87
Copy link
Author

Makes sense to me to combine FC+gVarNamesFixed and svN+gVarNamesNormal into two numeric vectors with optional names to simplify things.

E.g. c(beta_price = 0, beta_time = -0.5)

This is related to issue #75.

@ghost
Copy link

ghost commented Mar 16, 2016

How about?

  • gVarNamesNormal (par.random.names)
  • svN (par.random.sv)
  • gDIST (par.random.dist)
  • constraintsNorm (par.random.constraints)
  • gVarNamesFixed (par.fixed.names)
  • FC (par.fixed.sv)
  • gNCREP (iter.burnin)
  • gNEREP (iter.model)
  • gNSKIP (iter.skip)
  • gINFOSKIP (iter.trace)
  • priorVariance (pv)
  • degreesOfFreedom (df)
  • rho/rhoF (rho.random/rho.fixed)
  • targetAcceptanceNormal (target.ar.random)
  • targetAcceptanceFixed (target.ar.fixed)
  • gFULLCV (full.covariance)
  • gStoreDraws (keep.draws)
  • gSeed (seed)
  • gMINCOEF (can be deprecated and specified by the user in the
    likelihood function)
  • gMAXCOEF (can be deprecated and specified by the user in the
    likelihood function)
  • nodiagnostics (diagnostics; invert to avoid double negative)

On Tue, Mar 15, 2016 at 11:48 PM, Jeff Keller [email protected]
wrote:

Control argument names are outdated, occasionally inconsistent, and
confusing (particularly the "normal" and "fixed" nomenclature). I've set
the HBControl function up to easily catch deprecated arguments and direct
users to new usages/names. I don't think this is a pressing issue at all,
but wanted to get my thoughts down before I lose them.

Below are my suggestions: currentName (proposedName)

  • gVarNamesNormal (???)
  • gVarNamesFixed (???)
  • gDIST (dist)
  • FC (???)
  • svN (???)
  • gNCREP (???)
  • gNEREP (???)
  • gNSKIP (skip)
  • gINFOSKIP (trace)
  • priorVariance (pv)
  • degreesOfFreedom (df)
  • constraintsNorm (???)
  • rho/rhoF (???)
  • targetAcceptanceNormal (???)
  • targetAcceptanceFixed (???)
  • gFULLCV (???)
  • gStoreDraws (keep.draws)
  • gSeed (seed)
  • gMINCOEF (???)
  • gMAXCOEF (???)
  • nodiagnostics (diagnostics; invert to avoid double negative)


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#76

@jeffkeller87
Copy link
Author

I like these. What do you think about combining par.random.sv/.names and par.fixed.sv/.names down to par.random and par.fixed (optionally named)?

@ghost
Copy link

ghost commented Mar 16, 2016

That is okay with me.

On Wed, Mar 16, 2016 at 1:47 PM, Jeff Keller [email protected]
wrote:

I like these. What do you think about combining par.random.sv/.names and
par.fixed.sv/.names down to par.random and par.fixed (optionally named)?


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#76 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant