Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling on Mac #49

Open
DavidFletcherShef opened this issue Mar 1, 2023 · 0 comments
Open

Compiling on Mac #49

DavidFletcherShef opened this issue Mar 1, 2023 · 0 comments

Comments

@DavidFletcherShef
Copy link
Collaborator

DavidFletcherShef commented Mar 1, 2023

On recent MacOS there is an error generated about missing symbol GDisplayBestModeForParametersAndRefreshRateWithProperty

See https://discourse.glfw.org/t/osx-10-7-depreciated-function-issues/227 and http://core.ibex.org/src/org/ibex/plat/DarwinCarbonHeaders.h

The error can be removed using a patch to Steersuite⁩ > ⁨RateSetter-SteerSuite-master⁩ > ⁨external⁩ > ⁨glfw⁩ > ⁨lib⁩ > ⁨cocoa⁩ > cocoa_window.m

--- ./1/cocoa_window.m	2021-09-23 04:18:16.000000000 +0100
+++ ./2/cocoa_window.m	2023-03-01 13:57:12.000000000 +0000
@@ -706,14 +706,16 @@
             // I think it's safe to pass 0 to the refresh rate for this function
             // rather than conditionalizing the code to call the version which
             // doesn't specify refresh...
-            CGDisplayBestModeForParametersAndRefreshRateWithProperty(
+            //CGDisplayBestModeForParametersAndRefreshRateWithProperty(
+	    //Remove deprecated function and replace with new which required one fewer parameters. 
+            CGDisplayBestModeForParametersAndRefreshRate(
             CGMainDisplayID(),
             colorBits + fbconfig->alphaBits,
             width,
             height,
             wndconfig->refreshRate,
             // Controversial, see macosx_fullscreen.m for discussion
-            kCGDisplayModeIsSafeForHardware,
+            //kCGDisplayModeIsSafeForHardware,
             NULL);
 
         width = [[(id)fullscreenMode objectForKey:(id)kCGDisplayWidth] intValue];
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant