Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Snap-to-grid and erase toggles are set per tool #5004

Open
kwvanderlinde opened this issue Oct 17, 2024 · 1 comment
Open

[Bug]: Snap-to-grid and erase toggles are set per tool #5004

kwvanderlinde opened this issue Oct 17, 2024 · 1 comment
Labels

Comments

@kwvanderlinde
Copy link
Collaborator

kwvanderlinde commented Oct 17, 2024

Describe the Bug

When using drawing and template tools, we can set all sorts of things in the colour picker. When switch to a different drawing tool or different template tools, the snap-to-grid and erase toggle buttons are cleared. If we switch back to the first tool, those buttons' states are restored. The rest of the controls are preserved when switch tools.

To Reproduce

  1. Select the rectange drawing tool.
  2. Change the colours and layers. Also toggle on all the buttons (snap-to-grid, erase, line type).
  3. Select the oval drawing tool.
  4. Notice the colour picker is the same, except the snap-to-grid and erase toggles are off now.
  5. Select the rectangle drawing tool again.
  6. Notice the colour picker is back to the state it was in (2).

Expected Behaviour

All colour picker state is preserved when switching tools.

Screenshots

No response

MapTool Info

1.15.2

Desktop

Linux Mint 22

Additional Context

No response

@kwvanderlinde
Copy link
Collaborator Author

This behaviour looks like it was deliberately added (probably a long time ago). But I'm calling it a bug due to the inconsistency and surprise factor.

kwvanderlinde added a commit to kwvanderlinde/maptool that referenced this issue Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant