From 70b9c563a66986e6f9bdb1614e85c8e6ae6f90c1 Mon Sep 17 00:00:00 2001 From: Kenneth VanderLinde Date: Tue, 28 May 2024 13:13:14 -0700 Subject: [PATCH] Check isHidden() when dispatching HTML events to frames For dockable frames, the component itself is hidden if not the active tab so AWT's `isVisible()` returns false. However JIDE and the user consider the frame still open, which agrees with `!isHidden()`. --- .../net/rptools/maptool/client/ui/htmlframe/HTMLFrame.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/net/rptools/maptool/client/ui/htmlframe/HTMLFrame.java b/src/main/java/net/rptools/maptool/client/ui/htmlframe/HTMLFrame.java index ce95f272b4..a3b2ba9cbc 100644 --- a/src/main/java/net/rptools/maptool/client/ui/htmlframe/HTMLFrame.java +++ b/src/main/java/net/rptools/maptool/client/ui/htmlframe/HTMLFrame.java @@ -310,7 +310,7 @@ public void updateContents( /** Run all callback macros for "onChangeSelection". */ public static void doSelectedChanged() { for (HTMLFrame frame : frames.values()) { - if (frame.isVisible()) { + if (!frame.isHidden()) { HTMLPanelContainer.selectedChanged(frame.macroCallbacks); } } @@ -319,7 +319,7 @@ public static void doSelectedChanged() { /** Run all callback macros for "onChangeImpersonated". */ public static void doImpersonatedChanged() { for (HTMLFrame frame : frames.values()) { - if (frame.isVisible()) { + if (!frame.isHidden()) { HTMLPanelContainer.impersonatedChanged(frame.macroCallbacks); } } @@ -333,7 +333,7 @@ public static void doImpersonatedChanged() { public static void doTokenChanged(Token token) { if (token != null) { for (HTMLFrame frame : frames.values()) { - if (frame.isVisible()) { + if (!frame.isHidden()) { HTMLPanelContainer.tokenChanged(token, frame.macroCallbacks); } }