Remove change to consistently use LinkedHashMap

The change to `LinkedHashMap<>` should not cause any issues, even with serialization, since we copy the map contents
into our chosen implementation anyways. However, it does mean that new campaigns files with have `<linked-hash-map>` as
the values under `<lightSourcesMap>`, where they used to have `<map>`. So to avoid any possible issues, and to meet the
goal of zero campaign file changes in 1.18, we're going back to consistent `HashMap<>` for light source maps.

The ubiquitous copying of light source maps remains.

Author: kwvanderlinde

src/main/java/net/rptools/maptool/client/ui/campaignproperties/CampaignPropertiesDialog.java

@@ -29,7 +29,6 @@
 import java.util.Arrays;
 import java.util.Collections;
 import java.util.HashMap;
-import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.TreeMap;
@@ -270,7 +269,7 @@ private void copyCampaignToUI(CampaignProperties campaignProperties) {
               case NORMAL -> lightSources;
               case AURA -> auras;
             };
-        targetMap.computeIfAbsent(category, c -> new LinkedHashMap<>()).put(guid, source);
+        targetMap.computeIfAbsent(category, c -> new HashMap<>()).put(guid, source);
       }
     }
 
@@ -323,7 +322,7 @@ private void copyUIToCampaign() {
         var guid = sourceEntry.getKey();
         var source = sourceEntry.getValue();
 
-        newLights.computeIfAbsent(category, c -> new LinkedHashMap<>()).put(guid, source);
+        newLights.computeIfAbsent(category, c -> new HashMap<>()).put(guid, source);
       }
     }
 

src/main/java/net/rptools/maptool/model/CampaignProperties.java

@@ -126,7 +126,7 @@ public CampaignProperties(CampaignProperties properties) {
 
     // Play it safe. Don't keep the provided implementations but copy them.
     for (var entry : properties.lightSourcesMap.entrySet()) {
-      lightSourcesMap.put(entry.getKey(), new LinkedHashMap<>(entry.getValue()));
+      lightSourcesMap.put(entry.getKey(), new HashMap<>(entry.getValue()));
     }
 
     for (BooleanTokenOverlay overlay : properties.tokenStates.values()) {
@@ -164,7 +164,7 @@ public void mergeInto(CampaignProperties properties) {
 
     // Play it safe. Don't keep the provided implementations but copy them.
     for (var entry : lightSourcesMap.entrySet()) {
-      properties.lightSourcesMap.put(entry.getKey(), new LinkedHashMap<>(entry.getValue()));
+      properties.lightSourcesMap.put(entry.getKey(), new HashMap<>(entry.getValue()));
     }
     properties.lookupTableMap.putAll(lookupTableMap);
     properties.sightTypeMap.putAll(sightTypeMap);
@@ -237,7 +237,7 @@ public void setRemoteRepositoryList(List<String> list) {
   public Map<String, Map<GUID, LightSource>> getLightSourcesMap() {
     var copy = new TreeMap<String, Map<GUID, LightSource>>();
     for (var entry : lightSourcesMap.entrySet()) {
-      copy.put(entry.getKey(), new LinkedHashMap<>(entry.getValue()));
+      copy.put(entry.getKey(), new HashMap<>(entry.getValue()));
     }
     return copy;
   }
@@ -246,7 +246,7 @@ public void setLightSourcesMap(Map<String, Map<GUID, LightSource>> map) {
     lightSourcesMap.clear();
     // Play it safe. Don't keep the provided implementations but copy them.
     for (var entry : map.entrySet()) {
-      lightSourcesMap.put(entry.getKey(), new LinkedHashMap<>(entry.getValue()));
+      lightSourcesMap.put(entry.getKey(), new HashMap<>(entry.getValue()));
     }
   }
 
@@ -295,7 +295,7 @@ private void initLightSourcesMap() {
       Map<String, List<LightSource>> map = LightSource.getDefaultLightSources();
       for (var entry : map.entrySet()) {
         String key = entry.getKey();
-        Map<GUID, LightSource> lightSourceMap = new LinkedHashMap<>();
+        Map<GUID, LightSource> lightSourceMap = new HashMap<>();
         for (LightSource source : entry.getValue()) {
           lightSourceMap.put(source.getId(), source);
         }
@@ -492,7 +492,7 @@ protected Object readResolve() {
     lightSourcesMap = new TreeMap<>();
     if (oldLightSourcesMap != null) {
       for (var entry : oldLightSourcesMap.entrySet()) {
-        lightSourcesMap.put(entry.getKey(), new LinkedHashMap<>(entry.getValue()));
+        lightSourcesMap.put(entry.getKey(), new HashMap<>(entry.getValue()));
       }
     }
 
@@ -564,7 +564,7 @@ public static CampaignProperties fromDto(CampaignPropertiesDto dto) {
     dto.getLightSourcesMap()
         .forEach(
             (k, v) -> {
-              var map = new LinkedHashMap<GUID, LightSource>();
+              var map = new HashMap<GUID, LightSource>();
               v.getLightSourcesList()
                   .forEach(
                       l -> {

src/main/java/net/rptools/maptool/util/AuraSyntax.java

@@ -46,7 +46,7 @@ public class AuraSyntax {
   private static final Logger log = LogManager.getLogger(AuraSyntax.class);
 
   public Map<GUID, LightSource> parseAuras(String text, Iterable<LightSource> original) {
-    final var aurasMap = new LinkedHashMap<GUID, LightSource>();
+    final var aurasMap = new HashMap<GUID, LightSource>();
     final var reader = new LineNumberReader(new BufferedReader(new StringReader(text)));
     List<String> errlog = new LinkedList<>();
 
@@ -98,7 +98,7 @@ public Map<String, Map<GUID, LightSource>> parseCategorizedAuras(
           final var currentGroupName = line;
           currentGroupOriginalAuras =
               originalAuraMap.getOrDefault(currentGroupName, Collections.emptyMap()).values();
-          auraGroupMap = new LinkedHashMap<>();
+          auraGroupMap = new HashMap<>();
           auraMap.put(currentGroupName, auraGroupMap);
           continue;
         }

src/main/java/net/rptools/maptool/util/LightSyntax.java

@@ -46,7 +46,7 @@ public class LightSyntax {
   private static final Logger log = LogManager.getLogger(LightSyntax.class);
 
   public Map<GUID, LightSource> parseLights(String text, Iterable<LightSource> original) {
-    final var lightSourceMap = new LinkedHashMap<GUID, LightSource>();
+    final var lightSourceMap = new HashMap<GUID, LightSource>();
     final var reader = new LineNumberReader(new BufferedReader(new StringReader(text)));
     List<String> errlog = new LinkedList<>();
 
@@ -100,7 +100,7 @@ public Map<String, Map<GUID, LightSource>> parseCategorizedLights(
               originalLightSourcesMap
                   .getOrDefault(currentGroupName, Collections.emptyMap())
                   .values();
-          lightSourceMap = new LinkedHashMap<>();
+          lightSourceMap = new HashMap<>();
           lightMap.put(currentGroupName, lightSourceMap);
           continue;
         }