From c5d169a3ed6e620823bd537b1c32e87feb0b77fc Mon Sep 17 00:00:00 2001 From: Alexei Ivanov Date: Wed, 16 Oct 2024 05:33:02 +0000 Subject: [PATCH 1/4] Not important variation to create a dummy PR for CI testing. --- Dockerfile.rocm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Dockerfile.rocm b/Dockerfile.rocm index 832d6f0fa7db1..6e92d035ef684 100644 --- a/Dockerfile.rocm +++ b/Dockerfile.rocm @@ -284,3 +284,7 @@ ENV HIP_FORCE_DEV_KERNARG=1 CMD ["/bin/bash"] +# DONE + + + From 0053e14e410dc4db02e59baed8a1b44ea83a046f Mon Sep 17 00:00:00 2001 From: Alexei Ivanov Date: Wed, 16 Oct 2024 08:34:02 +0000 Subject: [PATCH 2/4] Skipy & numba updates in a timely manner. --- Dockerfile.rocm | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/Dockerfile.rocm b/Dockerfile.rocm index 6e92d035ef684..785a3ee1ffde6 100644 --- a/Dockerfile.rocm +++ b/Dockerfile.rocm @@ -170,6 +170,7 @@ if ls /install/*.whl; then \ fi # Build vLLM RUN cd vllm \ + && python3 -m pip install --upgrade numba scipy \ && python3 -m pip install -r requirements-rocm.txt \ && python3 setup.py clean --all \ && if [ ${USE_CYTHON} -eq "1" ]; then python3 setup_cython.py build_ext --inplace; fi \ @@ -246,7 +247,7 @@ RUN --mount=type=bind,from=export_pytorch,src=/,target=/install \ && pip install /install/*.whl; \ fi -RUN python3 -m pip install --upgrade numba scipy huggingface-hub[cli] +RUN python3 -m pip install --upgrade huggingface-hub[cli] RUN git clone -b nvtx_enabled https://github.com/ROCm/rocmProfileData.git \ && cd rocmProfileData/rpd_tracer \ @@ -284,7 +285,3 @@ ENV HIP_FORCE_DEV_KERNARG=1 CMD ["/bin/bash"] -# DONE - - - From 2fa5e14f0ddafea2add47be118856221a97ef881 Mon Sep 17 00:00:00 2001 From: Alexei Ivanov Date: Mon, 21 Oct 2024 19:57:10 +0000 Subject: [PATCH 3/4] fixing environment variables --- .buildkite/run-amd-test.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.buildkite/run-amd-test.sh b/.buildkite/run-amd-test.sh index f50fdd4fa583c..d7c05ec31cc5e 100755 --- a/.buildkite/run-amd-test.sh +++ b/.buildkite/run-amd-test.sh @@ -44,11 +44,11 @@ cleanup_docker echo "--- Resetting GPUs" -echo "reset" > ${BUILDKITE_META_DATA_RESET_TARGET} +echo "reset" > ${BUILDKITE_AGENT_META_DATA_RESET_TARGET} while true; do sleep 3 - if grep -q clean ${BUILDKITE_META_DATA_RESET_TARGET}; then + if grep -q clean ${BUILDKITE_AGENT_META_DATA_RESET_TARGET}; then echo "GPUs state is \"clean\"" break fi From 43b0a37d972270a7cfa0058aa4cbe7bda2f6c9b4 Mon Sep 17 00:00:00 2001 From: Alexei Ivanov Date: Tue, 22 Oct 2024 00:20:01 +0000 Subject: [PATCH 4/4] Changing the installation to use requirements-rocm.txt --- Dockerfile.rocm | 2 +- requirements-rocm.txt | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Dockerfile.rocm b/Dockerfile.rocm index 785a3ee1ffde6..ce7b4f0a96564 100644 --- a/Dockerfile.rocm +++ b/Dockerfile.rocm @@ -168,9 +168,9 @@ RUN --mount=type=bind,from=export_pytorch,src=/,target=/install \ if ls /install/*.whl; then \ pip install /install/*.whl; \ fi + # Build vLLM RUN cd vllm \ - && python3 -m pip install --upgrade numba scipy \ && python3 -m pip install -r requirements-rocm.txt \ && python3 setup.py clean --all \ && if [ ${USE_CYTHON} -eq "1" ]; then python3 setup_cython.py build_ext --inplace; fi \ diff --git a/requirements-rocm.txt b/requirements-rocm.txt index 9e3c4a86cd81d..7f83cbbc307a6 100644 --- a/requirements-rocm.txt +++ b/requirements-rocm.txt @@ -2,6 +2,7 @@ -r requirements-common.txt # Dependencies for AMD GPUs +numpy==1.26.4 awscli boto3 botocore @@ -9,4 +10,4 @@ ray >= 2.10.0 peft pytest-asyncio tensorizer>=2.9.0 -setuptools-scm>=8 \ No newline at end of file +setuptools-scm>=8