From 09f920d44899bfeac6147f5389c53fe23da3224a Mon Sep 17 00:00:00 2001 From: Luca Bruni Date: Mon, 6 Jan 2025 10:46:28 -0500 Subject: [PATCH 1/3] Disable CK_TIME_KERNEL by Default, Add as CMake Variable --- CMakeLists.txt | 5 +++++ include/ck/ck.hpp | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 191aad8721..9a29825b39 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -106,6 +106,11 @@ if(CK_USE_CODEGEN) add_definitions(-DCK_USE_CODEGEN) endif() +option(CK_TIME_KERNEL "Enable kernel time tracking" OFF) +if(CK_TIME_KERNEL) + add_definitions(-DCK_TIME_KERNEL) +endif() + include(getopt) # CK version file to record release version as well as git commit hash diff --git a/include/ck/ck.hpp b/include/ck/ck.hpp index 999eb0229c..eedc612066 100644 --- a/include/ck/ck.hpp +++ b/include/ck/ck.hpp @@ -17,7 +17,9 @@ CK_DECLARE_ENV_VAR_BOOL(CK_LOGGING) // to do: add various levels of logging with CK_LOG_LEVEL -#define CK_TIME_KERNEL 1 +#ifndef CK_TIME_KERNEL +#define CK_TIME_KERNEL 0 +#endif // constant address space for kernel parameter // https://llvm.org/docs/AMDGPUUsage.html#address-spaces From 0c8e8c411d90116fb408ab1b4dbd5c892d27beea Mon Sep 17 00:00:00 2001 From: Luca Bruni Date: Fri, 10 Jan 2025 11:34:34 -0500 Subject: [PATCH 2/3] Enable CK_TIME_KERNEL by Default, Maintaining CMake Variable Functionality. --- CMakeLists.txt | 6 ++++-- include/ck/ck.hpp | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 9a29825b39..a1d7cbccda 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -106,9 +106,11 @@ if(CK_USE_CODEGEN) add_definitions(-DCK_USE_CODEGEN) endif() -option(CK_TIME_KERNEL "Enable kernel time tracking" OFF) +option(CK_TIME_KERNEL "Enable kernel time tracking" ON) if(CK_TIME_KERNEL) - add_definitions(-DCK_TIME_KERNEL) + add_definitions(-DCK_TIME_KERNEL=ON) +else() + add_definitions(-DCK_TIME_KERNEL=OFF) endif() include(getopt) diff --git a/include/ck/ck.hpp b/include/ck/ck.hpp index eedc612066..18b664e976 100644 --- a/include/ck/ck.hpp +++ b/include/ck/ck.hpp @@ -18,7 +18,7 @@ CK_DECLARE_ENV_VAR_BOOL(CK_LOGGING) // to do: add various levels of logging with CK_LOG_LEVEL #ifndef CK_TIME_KERNEL -#define CK_TIME_KERNEL 0 +#define CK_TIME_KERNEL 1 #endif // constant address space for kernel parameter From e031134f2ceb05e4b6c704917f0c8c751b2295ef Mon Sep 17 00:00:00 2001 From: Luca Bruni Date: Fri, 10 Jan 2025 11:50:28 -0500 Subject: [PATCH 3/3] Fix build error. --- CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index a1d7cbccda..92e9da6b10 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -108,9 +108,9 @@ endif() option(CK_TIME_KERNEL "Enable kernel time tracking" ON) if(CK_TIME_KERNEL) - add_definitions(-DCK_TIME_KERNEL=ON) + add_definitions(-DCK_TIME_KERNEL=1) else() - add_definitions(-DCK_TIME_KERNEL=OFF) + add_definitions(-DCK_TIME_KERNEL=0) endif() include(getopt)