Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: interprocess event perf issue due to stream callback #127

Open
Epliz opened this issue Jan 16, 2025 · 1 comment
Open

[Issue]: interprocess event perf issue due to stream callback #127

Epliz opened this issue Jan 16, 2025 · 1 comment

Comments

@Epliz
Copy link

Epliz commented Jan 16, 2025

Problem Description

Hi,

As indicated at #104 , I have seen that the current implementation of interprocess events is suboptimal. In particular, the fact that it uses a stream callback to decrement the internal flags causes the CPU to not be able to queue further GPU work ahead.
I believe that the implementation could be made better by using monotonically increasing counters and stream memory wait operations. Using such monotonically increasing counters would remove the need for decreasing the counters with the CPU side as the CPU could just check if the counter value is greater than desired.

This is quite important to fix this as interprocess events are quite used for the multi process multi gpu applications.

Best regards,
Epliz

Operating System

Ubuntu 22.04

CPU

Intel xeon

GPU

MI300x

ROCm Version

ROCm 6.3.0

ROCm Component

No response

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

@ppanchad-amd
Copy link

Hi @Epliz. Internal ticket has been created to fix this issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants