Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

Do not use relative paths outside of install directory #18

Open
haampie opened this issue Aug 7, 2020 · 1 comment
Open

Do not use relative paths outside of install directory #18

haampie opened this issue Aug 7, 2020 · 1 comment

Comments

@haampie
Copy link

haampie commented Aug 7, 2020

Please change all occurrences of ../../hsa/lib and ../../lib to something that's not relative and hard-coded.

In certain package managers ../../lib cannot exist, since libraries are only available inside the package folders themselves. Also the name hsa is not guaranteed to be the install directory of the hsa package.

@ashwinma
Copy link
Contributor

ashwinma commented Aug 8, 2020

I can make the below change without any issue.

diff --git a/src/runtime/core/CMakeLists.txt b/src/runtime/core/CMakeLists.txt
index b0bd238..e3c301b 100644
--- a/src/runtime/core/CMakeLists.txt
+++ b/src/runtime/core/CMakeLists.txt
@@ -109,7 +109,6 @@ target_link_libraries(
   ${amd_comgr_LIBRARIES}
   ${LIBELF_LIBRARIES}
   ${ROCM_LIBRARIES}
-  -L${ROCM_LIBRARIES_DIR}/../hsa/lib
   -L${ROCM_LIBRARIES_DIR}
   -Wl,--enable-new-dtags
 )

Would the above and the de44c82 suffice for your requirements?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants