From fa14676e1a512a732f922fbed4661b86ce813daa Mon Sep 17 00:00:00 2001 From: Witold Baryluk Date: Fri, 4 Dec 2020 01:32:13 +0000 Subject: [PATCH] Don't pass raw -j to make `-j` means to use unlimited amount of workers. That is not a good idea on low core count machines, or big core count machines with not enough memory. It shouldn't be an issue for `clean` target, but it is bad practice. Use `nproc`. --- test_all.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test_all.sh b/test_all.sh index 1847ab1..ad88c02 100755 --- a/test_all.sh +++ b/test_all.sh @@ -77,7 +77,7 @@ echo : ${HIP_MAKEJ:="4"} echo "==== Rodinia ====" cd rodinia_3.0/hip -make clean -j ${HIP_MAKEJ} +make clean -j$(nproc) ${HIP_MAKEJ} make test cd ..