Skip to content
This repository has been archived by the owner on Dec 9, 2023. It is now read-only.

Config file support for main daemons #60

Open
dr-orlovsky opened this issue Sep 13, 2020 · 9 comments
Open

Config file support for main daemons #60

dr-orlovsky opened this issue Sep 13, 2020 · 9 comments
Labels
feature New functionality good first issue Good for newcomers low priority Tasks with small priority
Milestone

Comments

@dr-orlovsky
Copy link
Member

No description provided.

@dr-orlovsky dr-orlovsky added good first issue Good for newcomers feature New functionality low priority Tasks with small priority labels Sep 13, 2020
@dr-orlovsky dr-orlovsky added this to the v0.3.0 milestone Sep 13, 2020
@dr-orlovsky dr-orlovsky modified the milestones: v0.3, 0.5.0 Mar 4, 2021
@josediegorobles
Copy link

Hi, it's possible use the config crate for it?
Do you want to include all options in config file possibly?

@Kixunil
Copy link

Kixunil commented Apr 15, 2021

@josediegorobles this project tends to use configure_me, depending on circumstances.

@josediegorobles
Copy link

Ok @Kixunil, I will try to do a PR with this.

@josediegorobles
Copy link

Hi, tonight I read doc of configure_me and I think that it's too much duplication of code, one for clap/command line, another for files.
There are a crate, StructConf that reunites clap and config file and it's possible adapt the code to this crate. Do you think it's a good idea to try to make the config file read with this crate? If not I will try to do something this weekend with configure_me.

@Kixunil
Copy link

Kixunil commented Apr 16, 2021

configure_me does a lot of unix-y stuff correctly - handling of -abc switches, -abc=foo, non-UTF-8 (PathBuf...), env vars, can protect secrets, generates man pages...

So I suggest adding the missing features to configure_me instead - commands and subsections, so that clap can be removed. I don't have time to do it soon but I should be able to mentor you if you're interested.

@josediegorobles
Copy link

configure_me does a lot of unix-y stuff correctly - handling of -abc switches, -abc=foo, non-UTF-8 (PathBuf...), env vars, can protect secrets, generates man pages...

So I suggest adding the missing features to configure_me instead - commands and subsections, so that clap can be removed. I don't have time to do it soon but I should be able to mentor you if you're interested.

Sounds interesting, where I can start? I can't promise persistence but sure I can do something.

@Kixunil
Copy link

Kixunil commented Apr 17, 2021

I believe subcommands are the main missing feature that enables removing clap, please @dr-orlovsky correct me if I'm wrong and please look at the proposal of subcommands.

I opened Kixunil/configure_me#46 so you can take a look at it and try to make initial implementation that doesn't support fancy stuff.

@josediegorobles
Copy link

I believe subcommands are the main missing feature that enables removing clap, please @dr-orlovsky correct me if I'm wrong and please look at the proposal of subcommands.

I opened Kixunil/configure_me#46 so you can take a look at it and try to make initial implementation that doesn't support fancy stuff.

I will take a look and try to do something this weekend, I will comment in the issue.

@dr-orlovsky dr-orlovsky modified the milestones: 0.5.0, 0.9.0 Nov 16, 2022
@dr-orlovsky dr-orlovsky modified the milestones: v0.9.0, v0.10.0 Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New functionality good first issue Good for newcomers low priority Tasks with small priority
Projects
None yet
Development

No branches or pull requests

4 participants