Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RCP-240313B: Abstract script and type libraries out of consensus structures #221

Closed
wants to merge 1 commit into from
Closed

RCP-240313B: Abstract script and type libraries out of consensus structures #221

wants to merge 1 commit into from

Conversation

dr-orlovsky
Copy link
Member

Implementation of RGB-WG/RFC#4 on the consensus layer

@dr-orlovsky dr-orlovsky added refactoring Code refactoring *scalability* Issues affecting system scalability *consensus* Issues affecting distributed concensus labels Mar 13, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Mar 13, 2024
@dr-orlovsky dr-orlovsky requested review from crisdut and zoedberg March 13, 2024 14:43
@codecov Codecov
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 5.00000% with 57 lines in your changes are missing coverage. Please review.

Project coverage is 15.1%. Comparing base (2e01d87) to head (e3966db).

Files Patch % Lines
src/validation/logic.rs 0.0% 25 Missing ⚠️
src/vm/runtime.rs 0.0% 11 Missing ⚠️
src/validation/validator.rs 0.0% 9 Missing ⚠️
src/validation/consignment.rs 0.0% 7 Missing ⚠️
src/schema/script.rs 25.0% 3 Missing ⚠️
src/schema/schema.rs 33.3% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #221     +/-   ##
========================================
- Coverage    15.2%   15.1%   -0.1%     
========================================
  Files          33      33             
  Lines        4267    4187     -80     
========================================
- Hits          648     631     -17     
+ Misses       3619    3556     -63
Flag Coverage Δ
rust 15.1% <5.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr-orlovsky dr-orlovsky mentioned this pull request Mar 15, 2024
Closed
@zoedberg
Copy link
Contributor

To test this in rgb-lib I'm patching rgb-std with RGB-WG/rgb-std#166, but compilation fails. Since that PR is still in WIP I assume this is expected, but I'm reporting this because I don't feel confident to approve this PR without first being able to test it with rgb-lib

@dr-orlovsky
Copy link
Member Author

Yes, this is blocked upstream in RGB-WG/rgb-std#166 which has appeared to be much more invasive than I thought. ATM I am not able to finish it due to other priorities, so this PR should be postponed as well.

@dr-orlovsky dr-orlovsky mentioned this pull request Mar 27, 2024
Merged
@dr-orlovsky
Copy link
Member Author

A better alternative: #227

@dr-orlovsky dr-orlovsky self-assigned this Apr 7, 2024
@dr-orlovsky
Copy link
Member Author

Closing in favor of #227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crisdut crisdut Awaiting requested review from crisdut

@zoedberg zoedberg Awaiting requested review from zoedberg

Assignees

@dr-orlovsky dr-orlovsky

Labels
*consensus* Issues affecting distributed concensus refactoring Code refactoring *scalability* Issues affecting system scalability
Projects
RGB release v0.11
Status: Done
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dr-orlovsky @zoedberg