-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance address change functionality #50
Comments
Right now, we always open RevHub objects when we create them, meaning the user never has to worry about whether a hub has been opened. We could instead create a |
I agree with the approach, but I don't love the names. Maybe "findAddressesOfPotentialChildren" and "openAllChildren"? The first one is tricky, since we don't want to give the impression that we're just listing the addresses of the children that we're currently communicating with. The doc comment will need to spell out what's happening clearly. |
findAddressesOfRs485ConnectedChildren? It's quite long, but indicates what the devices are. Maybe devices is a better name than children in this case? |
It's RS-485 not USB, but otherwise I like it. The other thing to consider is the Control Hub, where we'll need to support doing this for USB and RS-485 children. |
How about |
Changing the Expansion Hub address should optionally (defaulting to true) perform discovery to check that no other devices on the bus have the same address. Additionally,
ParentExpansionHub
should have adiscoverChildren(openNewlyFoundChildren: boolean = true)
method that allows the application to prevent the user from selecting an address that's already being used on the bus.The text was updated successfully, but these errors were encountered: