refactor: don't use the same variable name for different types #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
force-pushed
the
aucampia/20230810T2243-dont-reuse-vars
branch
from
4ac6d82
to
a505b67
Compare
Mypy does not like it when the same variable name is used for different types.
aucampia
force-pushed
the
aucampia/20230810T2243-dont-reuse-vars
branch
from
a505b67
to
18c15c6
Compare
|
I'm fixing this because dmypy gets super confused here with #2520. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Mypy does not like it when the same variable name is used for different types.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.