-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default serialization format for conjunctive graph is turtle, but turtle cannot handle quads (AFAIK) #1674
Comments
I agree that TriG is best. TriG is explicitly a superset of Turtle for supporting multiple named graphs (RDF datasets). Notation 3 is not a W3C REC, and it extends things with more complex structures (variables, graphs as formulas ("complex values") etc.). It is not (AFAIK) a superset of TriG (if it was, it could make sense). |
…ault (RDFLib#1674) Created method ConjunctiveGraph.serialize(..., format='trig', ...). Because of typing problems I replaced some annotations in the overloaded methods of rdflib.Graph.serialize, so that in subclasses serialize knows, that it returns type(self) and not Graph. Because Graph.serialize annotations are still incompatible with ConjunctiveGraph.serialize added type: ignore [overriden] to let mypy skip that method.
…ault (RDFLib#1674) Created method ConjunctiveGraph.serialize(..., format='trig', ...). Because of typing problems I replaced some annotations in the overloaded methods of rdflib.Graph.serialize, so that in subclasses serialize knows, that it returns type(self) and not Graph. Because Graph.serialize annotations are still incompatible with ConjunctiveGraph.serialize added type: ignore [overriden] to let mypy skip that method.
@WhiteGobo made a PR to fix this, but it occurs to me now that fixing this is potentially a breaking change. There may be some mitigating factors, in that serializing a Given these two conditions hold, I think it is okay to include a fix in version 6; otherwise this has to be merged in a way that only has an effect on version 7 onwards[ref]. CC: @RDFLib/core-reviewers |
Next release will be 7 and we will generally be more open to breaking changes going forward. |
I believe turtle does not handle quads, but our default serialization format for ConjunctiveGraph is turtle as turtle does not override the default for Graph, I guess we should probably change this, question is to what.
I think TriG would make most sense, but the other option is n3.
The text was updated successfully, but these errors were encountered: