-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ContactPerson role for dmp.contributor is redundant with the dmp.contact in the model #19
Comments
We did this on purpose. We want always to have a contact person for a DMP, so that no DMP is an orphan.
|
There is a possibility of redundancy, due to the Datacite contributor types including a value of "ContactPerson", and this is unfortunate. However, I would not like to throw away the recommendation to use the DataCite contributorTypes just because of this potential redundancy, and I agree with Tomasz that we definitely want the mandatory contact person property as well. My recommendation: leave this as it is, and seek forgiveness later ;-) |
Isn't this contradictive with? #16 (comment) I think the decision for now is to remove the references to DataCite. |
Removing the link to DataCite also solves this issue. Any replacement we insert for Contributor types should "avoid" contact-person roles. |
Yes - the decision (based on the discussion in #16 (comment)) is to remove the connection to the DataCite 'roles'. |
The model has a exactly one contact, and zero or more contributors. However, the contributor.role can also be ContactPerson; this is redundant and inconsistent.
The text was updated successfully, but these errors were encountered: