Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContactPerson role for dmp.contributor is redundant with the dmp.contact in the model #19

Closed
rwwh opened this issue Nov 20, 2019 · 5 comments

Comments

@rwwh
Copy link

rwwh commented Nov 20, 2019

The model has a exactly one contact, and zero or more contributors. However, the contributor.role can also be ContactPerson; this is redundant and inconsistent.

@TomMiksa
Copy link
Contributor

We did this on purpose. We want always to have a contact person for a DMP, so that no DMP is an orphan.
Contributor is to:

  • list all people involved in managing data and writing the DMP
  • be able to answer questions from DMPs like “who will be responsible for implementing this DMP”

@paulwalk
Copy link
Contributor

There is a possibility of redundancy, due to the Datacite contributor types including a value of "ContactPerson", and this is unfortunate.

However, I would not like to throw away the recommendation to use the DataCite contributorTypes just because of this potential redundancy, and I agree with Tomasz that we definitely want the mandatory contact person property as well.

My recommendation: leave this as it is, and seek forgiveness later ;-)

@TomMiksa
Copy link
Contributor

Isn't this contradictive with? #16 (comment)

I think the decision for now is to remove the references to DataCite.

@rwwh
Copy link
Author

rwwh commented Nov 25, 2019

Removing the link to DataCite also solves this issue. Any replacement we insert for Contributor types should "avoid" contact-person roles.

@paulwalk
Copy link
Contributor

Yes - the decision (based on the discussion in #16 (comment)) is to remove the connection to the DataCite 'roles'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants