Upgrade clang-tidy on CI. (dmlc#5469)

* Correct all clang-tidy errors.
* Upgrade clang-tidy to 10 on CI.

Co-authored-by: Hyunsu Cho <[email protected]>

Author: trivialfis

.clang-tidy

@@ -1,21 +1,21 @@
 Checks: 'modernize-*,-modernize-make-*,-modernize-use-auto,-modernize-raw-string-literal,-modernize-avoid-c-arrays,-modernize-use-trailing-return-type,google-*,-google-default-arguments,-clang-diagnostic-#pragma-messages,readability-identifier-naming'
 CheckOptions:
-  - { key: readability-identifier-naming.ClassCase,           value: CamelCase  }
-  - { key: readability-identifier-naming.StructCase,          value: CamelCase  }
-  - { key: readability-identifier-naming.TypeAliasCase,          value: CamelCase  }
-  - { key: readability-identifier-naming.TypedefCase,          value: CamelCase  }
-  - { key: readability-identifier-naming.TypeTemplateParameterCase,          value: CamelCase  }
-  - { key: readability-identifier-naming.MemberCase,          value: lower_case  }
-  - { key: readability-identifier-naming.PrivateMemberSuffix,    value: '_'  }
-  - { key: readability-identifier-naming.ProtectedMemberSuffix,  value: '_'  }
-  - { key: readability-identifier-naming.EnumCase,          value: CamelCase  }
-  - { key: readability-identifier-naming.EnumConstant,          value: CamelCase  }
-  - { key: readability-identifier-naming.EnumConstantPrefix,          value: k  }
-  - { key: readability-identifier-naming.GlobalConstantCase,          value: CamelCase  }
-  - { key: readability-identifier-naming.GlobalConstantPrefix,          value: k  }
-  - { key: readability-identifier-naming.StaticConstantCase,          value: CamelCase  }
-  - { key: readability-identifier-naming.StaticConstantPrefix,          value: k  }
-  - { key: readability-identifier-naming.ConstexprVariableCase,          value: CamelCase  }
-  - { key: readability-identifier-naming.ConstexprVariablePrefix,          value: k  }
-  - { key: readability-identifier-naming.FunctionCase,          value: CamelCase  }
-  - { key: readability-identifier-naming.NamespaceCase,       value: lower_case }
+  - { key: readability-identifier-naming.ClassCase,                 value: CamelCase  }
+  - { key: readability-identifier-naming.StructCase,                value: CamelCase  }
+  - { key: readability-identifier-naming.TypeAliasCase,             value: CamelCase  }
+  - { key: readability-identifier-naming.TypedefCase,               value: CamelCase  }
+  - { key: readability-identifier-naming.TypeTemplateParameterCase, value: CamelCase  }
+  - { key: readability-identifier-naming.MemberCase,                value: lower_case }
+  - { key: readability-identifier-naming.PrivateMemberSuffix,       value: '_'        }
+  - { key: readability-identifier-naming.ProtectedMemberSuffix,     value: '_'        }
+  - { key: readability-identifier-naming.EnumCase,                  value: CamelCase  }
+  - { key: readability-identifier-naming.EnumConstant,              value: CamelCase  }
+  - { key: readability-identifier-naming.EnumConstantPrefix,        value: k          }
+  - { key: readability-identifier-naming.GlobalConstantCase,        value: CamelCase  }
+  - { key: readability-identifier-naming.GlobalConstantPrefix,      value: k          }
+  - { key: readability-identifier-naming.StaticConstantCase,        value: CamelCase  }
+  - { key: readability-identifier-naming.StaticConstantPrefix,      value: k          }
+  - { key: readability-identifier-naming.ConstexprVariableCase,     value: CamelCase  }
+  - { key: readability-identifier-naming.ConstexprVariablePrefix,   value: k          }
+  - { key: readability-identifier-naming.FunctionCase,              value: CamelCase  }
+  - { key: readability-identifier-naming.NamespaceCase,             value: lower_case }

Jenkinsfile

@@ -119,7 +119,7 @@ def ClangTidy() {
     echo "Running clang-tidy job..."
     def container_type = "clang_tidy"
     def docker_binary = "docker"
-    def dockerArgs = "--build-arg CUDA_VERSION=9.2"
+    def dockerArgs = "--build-arg CUDA_VERSION=10.1"
     sh """
     ${dockerRun} ${container_type} ${docker_binary} ${dockerArgs} python3 tests/ci_build/tidy.py
     """

include/xgboost/base.h

@@ -106,7 +106,7 @@ using bst_uint = uint32_t;  // NOLINT
 /*! \brief integer type. */
 using bst_int = int32_t;    // NOLINT
 /*! \brief unsigned long integers */
-using bst_ulong = uint64_t;
+using bst_ulong = uint64_t;  // NOLINT
 /*! \brief float type, used for storing statistics */
 using bst_float = float;  // NOLINT
 

include/xgboost/data.h

@@ -42,34 +42,34 @@ class MetaInfo {
   static constexpr uint64_t kNumField = 9;
 
   /*! \brief number of rows in the data */
-  uint64_t num_row_{0};
+  uint64_t num_row_{0};  // NOLINT
   /*! \brief number of columns in the data */
-  uint64_t num_col_{0};
+  uint64_t num_col_{0};  // NOLINT
   /*! \brief number of nonzero entries in the data */
-  uint64_t num_nonzero_{0};
+  uint64_t num_nonzero_{0};  // NOLINT
   /*! \brief label of each instance */
-  HostDeviceVector<bst_float> labels_;
+  HostDeviceVector<bst_float> labels_;  // NOLINT
   /*!
    * \brief the index of begin and end of a group
    *  needed when the learning task is ranking.
    */
-  std::vector<bst_group_t> group_ptr_;
+  std::vector<bst_group_t> group_ptr_;  // NOLINT
   /*! \brief weights of each instance, optional */
-  HostDeviceVector<bst_float> weights_;
+  HostDeviceVector<bst_float> weights_;  // NOLINT
   /*!
    * \brief initialized margins,
    * if specified, xgboost will start from this init margin
    * can be used to specify initial prediction to boost from.
    */
-  HostDeviceVector<bst_float> base_margin_;
+  HostDeviceVector<bst_float> base_margin_;  // NOLINT
   /*!
    * \brief lower bound of the label, to be used for survival analysis (censored regression)
    */
-  HostDeviceVector<bst_float> labels_lower_bound_;
+  HostDeviceVector<bst_float> labels_lower_bound_;  // NOLINT
   /*!
    * \brief upper bound of the label, to be used for survival analysis (censored regression)
    */
-  HostDeviceVector<bst_float> labels_upper_bound_;
+  HostDeviceVector<bst_float> labels_upper_bound_;  // NOLINT
 
   /*! \brief default constructor */
   MetaInfo()  = default;
@@ -360,7 +360,7 @@ class BatchIteratorImpl {
 template<typename T>
 class BatchIterator {
  public:
-  using iterator_category = std::forward_iterator_tag;
+  using iterator_category = std::forward_iterator_tag;  // NOLINT
   explicit BatchIterator(BatchIteratorImpl<T>* impl) { impl_.reset(impl); }
 
   void operator++() {
@@ -395,9 +395,9 @@ class BatchIterator {
 template<typename T>
 class BatchSet {
  public:
-  explicit BatchSet(BatchIterator<T> begin_iter) : begin_iter_(begin_iter) {}
-  BatchIterator<T> begin() { return begin_iter_; }
-  BatchIterator<T> end() { return BatchIterator<T>(nullptr); }
+  explicit BatchSet(BatchIterator<T> begin_iter) : begin_iter_(std::move(begin_iter)) {}
+  BatchIterator<T> begin() { return begin_iter_; }  // NOLINT
+  BatchIterator<T> end() { return BatchIterator<T>(nullptr); }  // NOLINT
 
  private:
   BatchIterator<T> begin_iter_;

include/xgboost/feature_map.h

@@ -65,7 +65,7 @@ class FeatureMap {
     return names_[idx].c_str();
   }
   /*! \return type of specific feature */
-  Type type(size_t idx) const {
+  Type TypeOf(size_t idx) const {
     CHECK_LT(idx, names_.size()) << "FeatureMap feature index exceed bound";
     return types_[idx];
   }

include/xgboost/generic_parameters.h

@@ -89,7 +89,7 @@ struct GenericParameter : public XGBoostParameter<GenericParameter> {
 
  private:
   // number of devices to use (deprecated).
-  int n_gpus {0};
+  int n_gpus {0};  // NOLINT
 };
 }  // namespace xgboost
 

include/xgboost/host_device_vector.h

@@ -130,7 +130,7 @@ class HostDeviceVector {
 
   void Resize(size_t new_size, T v = T());
 
-  using value_type = T;
+  using value_type = T;  // NOLINT
 
  private:
   HostDeviceVectorImpl<T>* impl_;