Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage class output #29

Open
keyvaann opened this issue Dec 11, 2024 · 8 comments
Open

Storage class output #29

keyvaann opened this issue Dec 11, 2024 · 8 comments

Comments

@keyvaann
Copy link
Collaborator

keyvaann commented Dec 11, 2024

Looking at the cluster/output.tf fie, I'm wondering why we're outputting the storage class names. What would be the benefit of having these shown to the user?
https://github.com/RADAR-base/RADAR-K8s-Infrastructure/blob/main/cluster/outputs.tf#L25

@keyvaann
Copy link
Collaborator Author

Looking at it further, I'm not sure why other values are outputted, since I don't see how they can be useful to the user.

@baixiac
Copy link
Member

baixiac commented Dec 12, 2024

They were there for users to know what valid SC values are accepted if they want to reconfigure the SC. Given there is now a validation on the defaut_storage_class variable, they may no longer be needed (removed in #35).

@keyvaann
Copy link
Collaborator Author

Looking at it further, I'm not sure why other values are outputted, since I don't see how they can be useful to the user.

@baixiac what do you think about the other values that are being outputted?

@baixiac
Copy link
Member

baixiac commented Dec 17, 2024

Just feel this is somehow related to #33 (comment). Any suggestions and can automation be realised to make outputs transparent to the users?

@keyvaann
Copy link
Collaborator Author

What do you mean by making the outputs transparent to users?

@baixiac
Copy link
Member

baixiac commented Jan 2, 2025

I meant ideally, the outputs don't need to be exposed to the people/CD who deploy RADAR. Somehow their values could be automatically injected into K8S manifests.

@keyvaann
Copy link
Collaborator Author

keyvaann commented Jan 6, 2025

I think we can make a yaml file and apply it to Kubernetes with kubectl terraform provider for this.

@baixiac
Copy link
Member

baixiac commented Jan 7, 2025

Yes, that would be the next milestone for automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants