-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: uniform naming of Macros #689
Comments
Further ideas: Otherwise, I can only comment on the S522 repository. (It makes perfect sense to compartmentalize access to the params on a need to know basis. Limit the damage a single person getting turned can do. Can we try to get the params classified as VS-NfD?) Without commenting on the specifics (and thus violating StGB § 353b), I think I can safely mention that the numbers of macros in S522 whose name matches the regular expression |
@ajedele for the macros there is not common naming convention, but somehow the convention is to use names that explain the use of the macro, for instance:
@klenze please, check our wiki for details: @klenze Last time I checked, R3BRoot seems to be mainly for the R3B experiment. So why do we have R3BRoot/macros/r3b/? |
The source code we use follows a very clear pattern:
Mapped2Cal
Cal2Hit
If there are other steps in between, they still mostly follow the scheme (Mapped2Precal or Mapped2Histo).
The macros used to execute the code have been renamed several times and are therefore much harder to find. For example, common naming convention was {detector name}+{step of calibration}.C. For example, TofdMapped2Cal.C. Recently, they have been renamed.
I would suggest, given the high overhead of R3BRoot and root, in general, for new students, we agree on a common naming convention for the macros.
The text was updated successfully, but these errors were encountered: