Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐞] V2 - Button Component ‘disabled’ Prop Not Updating Correctly #7251

Closed
caegdeveloper opened this issue Jan 13, 2025 · 1 comment
Closed
Labels
STATUS-1: needs triage New issue which needs to be triaged TYPE: bug Something isn't working

Comments

@caegdeveloper
Copy link

caegdeveloper commented Jan 13, 2025

Which component is affected?

Qwik Runtime

Describe the bug

There is a problem in the new version of v2 (it seems to me that this bug was introduced in alpha 5).

As it can be verified in the playground, the Button component does not change its property “disabled” although the parameter that receives from the parent makes that condition change.

In short, if in the SSR the button has the disabled set to “true”, then in the client it will never be disabled.
If in the SSR the button had the disable set to “false” in the client it can never be changed to disable “true”.

This can be seen by inspecting the HTML of the button

Reproduction

https://qwikdev-build-v2.qwik-8nx.pages.dev/playground/#v=2.0.0-alpha.5&f=7VaxCsIwEN39ipKpQhrQgmBtWhB3FzdxqGAnacWOIf%2FuJZdLU61FBzczpaG5XN693HsBaVZpOkYa3quvqxdw8Nbtax5N2ZReebbWL1B5gayAckdBcoZ2giEsLXTHe5k5t7ChlSUsoZyYIswQU4wLqPa55oOzijhWXvJ4JISwwYBiL4TGJNDLSHW0MFFm3H556Swj5uaJ%2ByGLWNMmT4uw6aQtXpIC%2BRhS0UwXB5Al76nsM%2FroJSIEuG1HqcnAKJ1bsD5VU8R1de0uJuyULXRYeiujwrNwDM8S0P5A2KTVN1MnM%2FRcB3cc26CJkaHVfN87FuvAHX%2FTOwZ0%2FHeOX3SOBw

Steps to reproduce

No response

System Info

npmPackages:
    @qwik.dev/core: 2.0.0-alpha.5
    @qwik.dev/router: 2.0.0-alpha.5

Additional Information

No response

@caegdeveloper caegdeveloper added STATUS-1: needs triage New issue which needs to be triaged TYPE: bug Something isn't working labels Jan 13, 2025
@caegdeveloper caegdeveloper changed the title [🐞] V2 - Button Component ‘Disabled’ Prop Not Updating Correctly [🐞] V2 - Button Component ‘disable’ Prop Not Updating Correctly Jan 13, 2025
@caegdeveloper caegdeveloper changed the title [🐞] V2 - Button Component ‘disable’ Prop Not Updating Correctly [🐞] V2 - Button Component ‘disabled’ Prop Not Updating Correctly Jan 13, 2025
@JerryWu1234 JerryWu1234 self-assigned this Jan 14, 2025
@Varixo
Copy link
Member

Varixo commented Jan 14, 2025

as per discord discussion this issue was created by accident. Everything here works as expected, there is missing usage of the others in the example. Closing it

@Varixo Varixo closed this as completed Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
STATUS-1: needs triage New issue which needs to be triaged TYPE: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants