Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with MiniMOTD #4

Open
jpenilla opened this issue Mar 13, 2022 · 3 comments
Open

Incompatible with MiniMOTD #4

jpenilla opened this issue Mar 13, 2022 · 3 comments

Comments

@jpenilla
Copy link

Currently Wires and MiniMOTD both redirect the same method for handling server list MOTDs.

@Redirect(method = "onRequest", at = @At(value = "INVOKE", target = "Lnet/minecraft/server/MinecraftServer;getServerMetadata()Lnet/minecraft/server/ServerMetadata;"))

https://github.com/jpenilla/MiniMOTD/blob/80ae413c9d3ba4fecb31a2dfa0ddafb011c428d4/fabric/src/main/java/xyz/jpenilla/minimotd/fabric/mixin/ServerStatusPacketListenerImplMixin.java#L48

I'm not sure what the best course of action is here for compatibility, given we both need to modify the return value... Since this seems like a common mixin, maybe we should try and get something into Fabric API?

@SmallSansSerif
Copy link

SmallSansSerif commented Mar 23, 2022

Ah, is there a work around?

Just found this out today. https://pastebin.com/q9k7M9sV

@otomir23
Copy link

Still no fix?

@Tempest-5ky
Copy link

Just leaving a comment here so i'll know when it's been fixed! I've been having the same issue argh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants