Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider providing Tiny v2 Intermediary instead of v1 #18

Open
EnnuiL opened this issue Jun 21, 2023 · 2 comments
Open

Consider providing Tiny v2 Intermediary instead of v1 #18

EnnuiL opened this issue Jun 21, 2023 · 2 comments
Labels
enhancement New feature or request v4

Comments

@EnnuiL
Copy link

EnnuiL commented Jun 21, 2023

It's simple: in the end of the maven field, a :v2 should be appended to it so that the Tiny v2 Intermediary is used instead of Tiny v1 (Example: net.fabricmc:intermediary:1.20.1:v2);
For a while, I've been testing with using the v2 distribution instead of v1, and it has shown to be pretty reliable, and Quilt Loader has been supporting it well; The only issue would be with the installer/launcher implementations, which will need to support classifiers (an example is JumpQuilt, to which I PR'd classifier support in the end);
A side-effect of this would be that the Tiny v1 format won't need to be supported by Quilt Mapping Tools and such if it no longer ends being used on such essential spots;

The perfect moment to pull this off would be with the Meta v4, but we'll need to test a lot and make sure we won't ever need to provide the Tiny v1 version of Intermediary

@EnnuiL
Copy link
Author

EnnuiL commented Jun 21, 2023

Relevant notes here:
From past tests of mine, I've determined that the vanilla Minecraft launcher (which also covers CurseForge and friends), the MMC family (MultiMC, Prism Launcher, etc.), ATLauncher, and Technic Launcher are all launchers that support version classifiers on maven paths; The only thing that didn't support it was JumpQuilt, which was addressed by a PR adding support for it;
At this point, I believe that not supporting version classifiers at this point is a rookie mistake that is usually fixed on a launcher/tool's early lifespan and therefore we shouldn't worry about any potential breakage on that area

The only potential breakage we need to worry about is about whenever the first Intermediary that shares a version with Hashed (see #13) works with the first Quilt Loader release under the Intermediary v2 distribution; I'll investigate this myself

@EnnuiL
Copy link
Author

EnnuiL commented Jun 21, 2023

Update: it appears that all Intermediary versions had Tiny v2 distributions published retroactively, making issue #13 not a mandatory requirement for going forward with the change;

Testing with the earliest Quilt Loader version available through the meta (0.16.0-beta.1) and the earliest Intermediary sharing a Hashed version (1.19.4), I can determine that it is safe to go forward with the migration

@ix0rai ix0rai added the enhancement New feature or request label Nov 22, 2024
@ix0rai ix0rai added the v4 label Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v4
Projects
None yet
Development

No branches or pull requests

2 participants