Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QSL's handling of builtin resource packs conflicts with Fabric API #322

Open
EnnuiL opened this issue Jul 9, 2023 · 4 comments
Open

QSL's handling of builtin resource packs conflicts with Fabric API #322

EnnuiL opened this issue Jul 9, 2023 · 4 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@EnnuiL
Copy link
Contributor

EnnuiL commented Jul 9, 2023

With fabric#3164 allowing builtin resource pack extensions to override vanilla textures, we've got into a situation where we have two intentional behavior conflict with each other, which could theoretically be solved by a mixin on QFAPI's side but effectively? it would make QSL's behavior barely appear in practice;

In order to avoid a change on that area, I'd advocate for expanding the support for builtin resource pack extensions by having any resource pack be able to have such folders inside, in order to primarily allow builtin mod resource packs to modify vanilla Programmer's Art and High Contrast textures, since I believe having the mod itself attempt to override the vanilla textures without a builtin mod resource pack is bad practice due to how you can barely do anything about it and its potential to break stuff

Other than that? I believe that there's no other option but to flip the boolean in order to prevent breaking Fabric mods

@EnnuiL EnnuiL added bug Something isn't working enhancement New feature or request labels Jul 9, 2023
@LambdAurora
Copy link
Contributor

I don't like it but given Sodium needs it, then we'll change.

@EnnuiL
Copy link
Contributor Author

EnnuiL commented Jul 9, 2023

That's the thing: if we managed to make so Sodium would have to make a separate on-by-default pack with the programmer_art folder being supported there? We could avoid this situation; well, at least if fabric ends copying us on that aspect;

@LambdAurora
Copy link
Contributor

No, that's a shit solution.

It overcomplexify everything for no good.

@EnnuiL
Copy link
Contributor Author

EnnuiL commented Jul 9, 2023

fair enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants