Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Map Color in Map components to Tint Color #609

Open
OroArmor opened this issue Jul 15, 2024 · 0 comments
Open

Rename Map Color in Map components to Tint Color #609

OroArmor opened this issue Jul 15, 2024 · 0 comments
Labels
s: small PRs with less than 200 lines t: refactor proposes a refactor

Comments

@OroArmor
Copy link
Member

OroArmor commented Jul 15, 2024 •
edited
Loading 

 FIELD f_pragnhex NO_TINT I
 METHOD m_ujimkecx isTintable ()Z

I think this is slightly better. I think refactoring mapColor to tintColor in several places is probably a good idea.
Originally posted by @OroArmor in #608 (comment)

I feel like map color gives the wrong impression since these are icons that are tinted based on whether they have been uncovered. Stuff like the banner icons cannot be part of this system, since they will always be discovered
@ix0rai ix0rai added t: refactor proposes a refactor s: small PRs with less than 200 lines labels Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
s: small PRs with less than 200 lines t: refactor proposes a refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OroArmor @ix0rai