Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run diff workflow on PRs #489

Open
Antikyth opened this issue Sep 6, 2023 · 4 comments
Open

Run diff workflow on PRs #489

Antikyth opened this issue Sep 6, 2023 · 4 comments
Labels
t: toolchain changes to the quilt mappings toolchain

Comments

@Antikyth
Copy link
Contributor

Antikyth commented Sep 6, 2023

I imagine this is not possible, given this comment:
https://github.com/QuiltMC/quilt-mappings/blob/23w35a/.github/actions/diff-uploader/index.js#L94-L101
But I think it is good to make an issue for this anyway, as if that is true, then that TODO can be removed and replaced by a brief comment explaining why it's not possible.

@Antikyth
Copy link
Contributor Author

Antikyth commented Sep 6, 2023

If not, perhaps adding another way for diffs to be viewed would be possible. Like, I know the update base workflow works on PRs.

@OroArmor
Copy link
Member

OroArmor commented Sep 6, 2023

I believe it's a permissions issue that prevents the comment on the pr. I think i said something somewhere, I wonder if I can find it.

@Antikyth
Copy link
Contributor Author

Antikyth commented Sep 6, 2023

@rustbot is used in the Rust repo to reply to PRs automatically, and @bors is used in response to command comments to do certain things. Just for reference.

@Antikyth
Copy link
Contributor Author

Antikyth commented Sep 6, 2023

@rustbot is used in the Rust repo to reply to PRs automatically, and @bors is used in response to command comments to do certain things. Just for reference.

How triagebot works

Triagebot consists of a webserver with several endpoints. The /github-hook and /zulip-hook endpoints receive webhook notifications from the respective services. Triagebot can then respond to those notifications to perform various actions such as adjusting labels.

@ix0rai ix0rai added the t: toolchain changes to the quilt mappings toolchain label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: toolchain changes to the quilt mappings toolchain
Projects
None yet
Development

No branches or pull requests

3 participants