Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad AO names #455

Open
OroArmor opened this issue Jun 29, 2023 · 0 comments
Open

Bad AO names #455

OroArmor opened this issue Jun 29, 2023 · 0 comments
Labels
s: tiny PRs with less than 50 lines t: refactor proposes a refactor

Comments

@OroArmor
Copy link
Member

quilt-mappings/mappings/net/minecraft/client/render/block/BlockModelRenderer.mapping

Lines 114 to 121 in f0e8cd2

METHOD m_ugzhmpxw getInt (Lnet/minecraft/unmapped/C_txtbiemp;Lnet/minecraft/unmapped/C_xjeuupup;Lnet/minecraft/unmapped/C_hynzadkk;)I
ARG 1 state
ARG 2 world
ARG 3 pos
METHOD m_xwopukmv getFloat (Lnet/minecraft/unmapped/C_txtbiemp;Lnet/minecraft/unmapped/C_xjeuupup;Lnet/minecraft/unmapped/C_hynzadkk;)F
ARG 1 state
ARG 2 blockView
ARG 3 pos

These method names are bad, they should be getLight and getAo
@ix0rai ix0rai added t: refactor proposes a refactor s: tiny PRs with less than 50 lines labels Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
s: tiny PRs with less than 50 lines t: refactor proposes a refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OroArmor @ix0rai