Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp field to Maven POM when releasing #300

Open
Scrumplex opened this issue May 1, 2023 · 1 comment
Open

Add timestamp field to Maven POM when releasing #300

Scrumplex opened this issue May 1, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Scrumplex
Copy link
Contributor

Scrumplex commented May 1, 2023

Some users might want to know when a version of the loader was released. Prism Launcher currently tries to guess this by downloading all loader Jars from Quilt Maven and extracting the oldest timestamp present inside the archive.

An alternate approach to this would be to provide a timestamp in the Maven POM file.

The format allows for a properties field with arbitrary key-value mappings.[1] Additionally Gradle allows customizing the generated POM file before it is being pushed.[2]

For the sake of reproducibility, the timestamp should probably be of the last Git commit at build time.

See PrismLauncher/meta#18 for reasoning on why a stable release timestamp field would be beneficial.

Edit: eventually I would want this for other artifacts in Quilt Maven too, but Loader is the important one for now.

@TheGlitch76
Copy link
Member

I'll look in to implementing this.

However, I can't do anything about older JARs. You'll have to find some way to statically store that information.

@TheGlitch76 TheGlitch76 added the enhancement New feature or request label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants