Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ESLint to project #38

Open
2 tasks done
mnyon-grandkru opened this issue May 13, 2023 · 1 comment · May be fixed by #74
Open
2 tasks done

Add ESLint to project #38

mnyon-grandkru opened this issue May 13, 2023 · 1 comment · May be fixed by #74
Labels
good first issue Good for newcomers hacktoberfest

Comments

@mnyon-grandkru
Copy link
Contributor

mnyon-grandkru commented May 13, 2023 •
edited by colinwilliams91
Loading

We need to add ESLint to the project in order to catch code issues that transpire. This includes:

We can also have discussions on which rules make sense and which don't, but that's outside the ticket itself
@mnyon-grandkru mnyon-grandkru moved this from Todo to In Progress in Frontend Roadmap May 20, 2023
mnyon-grandkru added a commit that referenced this issue May 20, 2023
@mnyon-grandkru
#38: Added ESLint configuration file
d0c262a
mnyon-grandkru added a commit that referenced this issue May 20, 2023
@mnyon-grandkru
Updated package.json tasks for #38; after eslint --fix
5a46570 
Changed the eslint task path to reflect the path that works for this
repository, specifically "src/components/** src/App.t*"

Also fixed a variable assigment in src/components/navbar/Navbar.tsx
mnyon-grandkru added a commit that referenced this issue May 23, 2023
@mnyon-grandkru
#38: Add eslint
9aee426
mnyon-grandkru added a commit that referenced this issue May 23, 2023
@mnyon-grandkru
#38: Disabled eslint invocations
f80f16f
@mnyon-grandkru mnyon-grandkru moved this from In Progress to In Review in Frontend Roadmap Jun 13, 2023
@mnyon-grandkru mnyon-grandkru moved this from In Review to Done in Frontend Roadmap Jun 13, 2023
This was referenced Sep 3, 2023
Open
Open
@colinwilliams91
Copy link

Here are a couple references as a good starting point - eslint-config-airbnb npm with 3.5 mil downloads weekly

a little more info for cross referencing with typescript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest
Projects
Frontend Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

73 create bug issue template and eslint hook in actions QueerGlobal/qg-frontend-v2
2 participants
@mnyon-grandkru @colinwilliams91