Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include "Create Qubes VM" in System Tools in Applications Menu, so it shows up / is available in Whisker Menu #6561

Open
mfc opened this issue Apr 26, 2021 · 5 comments · May be fixed by QubesOS/qubes-manager#393
Open

include "Create Qubes VM" in System Tools in Applications Menu, so it shows up / is available in Whisker Menu #6561

mfc opened this issue Apr 26, 2021 · 5 comments · May be fixed by QubesOS/qubes-manager#393
Assignees
@alimirjamali
Labels
C: desktop-linux-xfce4 Support for XFCE4 C: manager/widget P: minor Priority: minor. The lowest priority, below "default." pr submitted A pull request has been submitted for this issue. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. ux User experience

Comments

@mfc
Copy link
Member

mfc commented Apr 26, 2021

The problem you're addressing (if any)

R4.0

in XFCE, the option "Create Qubes VM" only exists in Applications Menu and not Whisker Menu (or other Menus), because the option "Create Qubes VM" does not exist in System Tools. all other Qubes-specific options exist ("Backup Qubes", "Restore Qubes", "Qube Manager", etc).

Describe the solution you'd like

include "Create Qubes VM" as an option listed in System Tools for Application Menu (same as all other Qubes-specific actions). then for users of Whisker Menu (or other menus) they can access it (and favorite it, for easy access).

I think that would be simplest to implement, and is not Whisker Menu-specific (doesn't involve Whisker Menu).
@mfc mfc added T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. P: minor Priority: minor. The lowest priority, below "default." C: desktop-linux-xfce4 Support for XFCE4 labels Apr 26, 2021
@andrewdavidwong andrewdavidwong added this to the TBD milestone Apr 26, 2021
@ninavizz
Copy link
Member

Honestly, this is kinda where I'd like to re-situate it in the new appmenu, too. :)

@andrewdavidwong andrewdavidwong added the ux User experience label May 12, 2021
@ninavizz
Copy link
Member

Rethinking this a bit @mfc a question for you: why would (or should?) a user initiate this task from the appmenu, and not qube manager? Asking to ask, not because I feel strongly one way or another—apart from wanting to reduce redundancy and keep things clean.

@mfc
Copy link
Member Author

mfc commented May 24, 2021

currently all Qubes management functionality exists outside the Qube Manager in System Tools and in widgets, coming out of #2132.

this ticket is to create consistency between the XFCE Applications Menu and the Whisker Menu, as the "Create Qubes VM" item seems to be manually patched to the Applications Menu main list unlike all other Qubes-specific actions which are listed in System Tools, and because of this this particular item is not included in the Whisker Menu at all. this then requires the user of a Whisker Menu to open the Qube Manager for this task, while a user of the Application Menu does not need to open the Qube Manager for this task.

@andrewdavidwong andrewdavidwong removed this from the Release TBD milestone Aug 13, 2023
@alimirjamali
Copy link

I think that it might be a good time to revisit this relatively old small issue from 2021.

Both of them show up in Whisker menu (picture below). So this issue might be already solved. The only difference is that the 1st one is not included in Qubes Tools group. I will submit a small patch to do so. So it would also show up in the xfce4-panel menu.

In the meantime, Qubes OS Project lead view from #9174 :

Anyway, for the old create qube dialog, I would prefer to simply remove it (and make qubes manager use the new one).

create_qube

alimirjamali added a commit to alimirjamali/qubes-manager that referenced this issue Nov 9, 2024
@alimirjamali
Add Create Qubes VM to the xfce4-panel menu
f35ff8f 
resolves: QubesOS/qubes-issues#6561
@alimirjamali alimirjamali linked a pull request Nov 9, 2024 that will close this issue
Open
@andrewdavidwong andrewdavidwong added the pr submitted A pull request has been submitted for this issue. label Nov 10, 2024
alimirjamali added a commit to alimirjamali/qubes-manager that referenced this issue Nov 10, 2024
@alimirjamali
Add Create Qubes VM to the xfce4-panel menu
be68559 
resolves: QubesOS/qubes-issues#6561

Also adding a missing dependency to repo files
alimirjamali added a commit to alimirjamali/qubes-manager that referenced this issue Nov 10, 2024
@alimirjamali
Add Create Qubes VM to the xfce4-panel menu
14cc82d 
resolves: QubesOS/qubes-issues#6561

Also adding a missing dependency to repo files
alimirjamali added a commit to alimirjamali/qubes-manager that referenced this issue Nov 16, 2024
@alimirjamali
Retire old qubes-vm-create dialog
c79cbf5 
Retire the the old PyQt based `qubes-vm-create` dialog and replace it
with GTK based `qubes-new-qube` for Qube Manager.

resolves: QubesOS/qubes-issues#6561
@alimirjamali
Copy link

Change of plans:

According the to PR discussions:

As noted in the other issue, IMO better to simply remove the old create qube dialog (and replace its use with the new one). I'll pick just the dependency fix from here

The PR is amended to make the new dialog the default (if desktop-manager-linux is installed). And start menu entry for the old dialog is deleted. But the actual old dialog executable is kept for the time (maybe till r4.3.1). Then its UI files and the code will be purged.

alimirjamali added a commit to alimirjamali/qubes-manager that referenced this issue Nov 25, 2024
@alimirjamali
Retire old qubes-vm-create dialog
e4f6046 
Retire the the old PyQt based `qubes-vm-create` dialog and replace it
with GTK based `qubes-new-qube` for Qube Manager.

resolves: QubesOS/qubes-issues#6561
alimirjamali added a commit to alimirjamali/qubes-manager that referenced this issue Nov 25, 2024
@alimirjamali
Retire old qubes-vm-create dialog
210f867 
Retire the the old PyQt based `qubes-vm-create` dialog and replace it
with GTK based `qubes-new-qube` for Qube Manager.

resolves: QubesOS/qubes-issues#6561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alimirjamali alimirjamali

Labels
C: desktop-linux-xfce4 Support for XFCE4 C: manager/widget P: minor Priority: minor. The lowest priority, below "default." pr submitted A pull request has been submitted for this issue. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. ux User experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Retire old qubes-vm-create dialog alimirjamali/qubes-manager
4 participants
@mfc @alimirjamali @ninavizz @andrewdavidwong