Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop-in directory for initialization scripts companion to /rw/config/rc.local #8690

Closed
ben-grande opened this issue Nov 7, 2023 · 13 comments · Fixed by QubesOS/qubes-core-agent-linux#474
Labels
C: core P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. r4.2-vm-bookworm-stable r4.2-vm-bullseye-stable r4.2-vm-centos-stream8-stable r4.2-vm-fc37-stable r4.2-vm-fc38-stable r4.2-vm-fc39-stable
Milestone

Comments

@ben-grande
Copy link

How to file a helpful issue

The problem you're addressing (if any)

Currently when orchestrating QubesOS deployment, most files I change are intended for packages as they have drop-in configuration directory, /etc/qubes/policy.d/*.policy, /etc/ssh/sshd_config.d/*.conf, /etc/apt/sources.list.d/*.(sources|list), including /rw/config/qubes-bind-dirs.d/*.conf, but /rw/config/rc.local does not have an equivalent.

When orchestrating qubes deployment, initialization calls have to be written to /rw/config/rc.local, but the file can't be replaced, because there is a possibility of having user modifications in it on multiple packages managing the same file.

Currently I am using Salt module file.append for rc.local, the only file that I am currently using this module in all my states is rc.local.

The solution you'd like

I know I can create my own sourcing mechanism in rc.local

for f in /rw/config/rc.local.d/*.conf
  test -r "$f" || continue
  . "$f"
done

But it would be much better if this was the upstream default for packagers to not mess with user configuration.

The value to a user, and who that user might be

The value to a user is not having their configuration overriden by a packages.

The value to a packager is not having to mess with user configuratio, with an easy drop-in configuration to apply at qube boot.

@ben-grande ben-grande added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: enhancement labels Nov 7, 2023
@andrewdavidwong andrewdavidwong added the R: self-closed Voluntarily closed by the person who opened it before another resolution occurred. label Nov 21, 2023
@ben-grande ben-grande reopened this Nov 21, 2023
@ben-grande
Copy link
Author

ben-grande commented Nov 21, 2023

Although no dicsussion was made about it, not in favor or opposing to it, it follows the same methods used in for parsing qubes-firewall.d.

I would like to ask for the label R: self-closed to be removed, it was my mistake it was closed and appears to be an automated action. Also please add pr submitted.

@marmarek marmarek added pr submitted A pull request has been submitted for this issue. and removed R: self-closed Voluntarily closed by the person who opened it before another resolution occurred. labels Nov 22, 2023
ben-grande added a commit to ben-grande/qubes-core-agent-linux that referenced this issue Nov 25, 2023
@andrewdavidwong andrewdavidwong added this to the Release 4.2 milestone Dec 4, 2023
@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing bullseye-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing bookworm-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.2 testing repository for the CentOS centos-stream8 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-agent-linux (including package core-agent-linux) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-agent-linux (including package core-agent-linux) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-agent-linux (including package core-agent-linux) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.2 stable repository for the CentOS centos-stream8 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.2 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.2 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-agent-linux (including package core-agent-linux) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-agent-linux (including package core-agent-linux) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-agent-linux (including package core-agent-linux) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: core P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. r4.2-vm-bookworm-stable r4.2-vm-bullseye-stable r4.2-vm-centos-stream8-stable r4.2-vm-fc37-stable r4.2-vm-fc38-stable r4.2-vm-fc39-stable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants