qvm-prefs: Don't falsely report 'no such property' #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HW42
force-pushed
the
simon/fix-no-such-prop-msg
branch
from
dbecdec to
bcef7af
Compare
HW42
force-pushed
the
simon/fix-no-such-prop-msg
branch
from
bcef7af to
25c3254
Compare
Previously we printed a 'no such property' error for all exceptions that are an instance of AttributeError which includes QubesPropertyAccessError and therefore generated confusing error messages. Print them only in case of QubesNoSuchPropertyError. Fixes QubesOS/qubes-issues#8666 Related to QubesOS/qubes-issues#5005
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
==========================================
- Coverage 75.07% 75.03% -0.04%
==========================================
Files 51 51
Lines 7815 7815
==========================================
- Hits 5867 5864 -3
- Misses 1948 1951 +3 ☔ View full report in Codecov by Sentry. |
marmarek
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we printed a 'no such property' error for all exceptions that are an instance of AttributeError which includes
QubesPropertyAccessError and therefore generated confusing error messages. Print them only in case of QubesNoSuchPropertyError.
Fixes QubesOS/qubes-issues#8666
Related to QubesOS/qubes-issues#5005