Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/usr/lib/qubes/cleanup-dispvms hangs #8619

Closed
DemiMarie opened this issue Oct 17, 2023 · 9 comments
Closed

/usr/lib/qubes/cleanup-dispvms hangs #8619

DemiMarie opened this issue Oct 17, 2023 · 9 comments
Assignees
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: core P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. R: duplicate Resolution: Another issue exists that is very similar to or subsumes this one.

Comments

@DemiMarie
Copy link

How to file a helpful issue

Qubes OS release

R4.2

Brief summary

/usr/lib/qubes/cleanup-dispvms hangs

Steps to reproduce

Not sure. This happened once for me.

Expected behavior

It doesn’t hang, or at least does not hang the boot process.

Actual behavior

Freezes and hangs the boot process.

@DemiMarie DemiMarie added T: bug P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. affects-4.2 This issue affects Qubes OS 4.2. labels Oct 17, 2023
@DemiMarie DemiMarie self-assigned this Oct 17, 2023
DemiMarie added a commit to DemiMarie/qubes-core-admin that referenced this issue Oct 17, 2023
This ensures that if there is a bug and the service hangs, the user is
still able to use the system eventually, rather than having to edit the
kernel command line to recover.

Fixes: QubesOS/qubes-issues#8619
@marmarek
Copy link
Member

Which dom0 kernel? If 6.5, it might be #8575

@DemiMarie
Copy link
Author

Which dom0 kernel? If 6.5, it might be #8575

uname -r gives 6.1.57-1.qubes.fc37.x86_64.

@andrewdavidwong andrewdavidwong added C: core needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Oct 17, 2023
@rustybird
Copy link

Did you by any chance boot with preempt=full when it happened?

@DemiMarie
Copy link
Author

Did you by any chance boot with preempt=full when it happened?

Yes, why do you ask?

@rustybird
Copy link

rustybird commented Oct 18, 2023

Just a hunch. No smoking gun yet :)

I've had what might have been a similar kind of hang like @marmarek's in #8575 a week or two ago, on shutting down a VM while lots of I/O was going on elsewhere. Unfortunately I didn't trigger a sysrq "Show Blocked State" back then to compare. His does involve dm-crypt. My system (which is on the newest kernel-latest 6.5.x) uses Btrfs not LVM; maybe LVM is just a bit more likely, if even that, to trigger some bug in the device-mapper or a lower layer of the storage stack?

And so I've been wondering if the scheduling change in kernel-latest v6.5.5+ could make this hypothetical bug more likely to cause an actual hang. Although that's probably because the recent LWN article series on reworking the kernel's preemption code (part 1, part 2) has primed me to see it as a potential source of trouble.

@DemiMarie
Copy link
Author

@rustybird I don’t think this was a kernel deadlock. systemctl restart qubesd.service solved the problem.

@rustybird
Copy link

rustybird commented Oct 18, 2023

So qubes-core.service was hanging during boot before login, and running systemctl restart qubesd.service (how?) unwedged it?

@DemiMarie
Copy link
Author

Duplicate of #8754 which has more information as to the actual cause.

@DemiMarie DemiMarie added the R: duplicate Resolution: Another issue exists that is very similar to or subsumes this one. label Dec 8, 2023
Copy link

github-actions bot commented Dec 8, 2023

This issue has been closed as a "duplicate." This means that another issue exists that is very similar to or subsumes this one. If any useful information on this issue is not already present on the other issue, please add it in a comment on the other issue. Here are some common cases of duplicate issues:

  • The other issue is closed. The other issue being closed does not prevent this issue from duplicating it. We will examine the closed issue and, if appropriate, reopen it.
  • The other issue is for a different Qubes release. We usually maintain only one issue for all affected Qubes releases.
  • The other issue is very old. The mere age of an issue is not, by itself, a relevant factor when determining duplicates.

By default, the newer issue will be closed in favor of the older issue. However, we make exceptions when we determine that it would be significantly more useful to keep the newer issue open instead of the older one.

We respect the time and effort you have taken to file this issue, and we understand that this outcome may be unsatisfying. Please accept our sincere apologies and know that we greatly value your participation and membership in the Qubes community.

If anyone reading this believes that this issue was closed in error or that the resolution of "duplicate" is not accurate, please leave a comment below saying so, and we will review this issue again. For more information, see How issues get closed.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 8, 2023
@andrewdavidwong andrewdavidwong removed the needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. label Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: core P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. R: duplicate Resolution: Another issue exists that is very similar to or subsumes this one.
Projects
None yet
Development

No branches or pull requests

4 participants