Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GUI for changing encryption password #7748

Closed
marmarta opened this issue Sep 10, 2022 · 6 comments
Closed

Create GUI for changing encryption password #7748

marmarta opened this issue Sep 10, 2022 · 6 comments
Assignees
Labels
C: manager/widget cryptography This issue pertains to cryptography. P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. ux User experience
Milestone

Comments

@marmarta
Copy link
Member

The problem you're addressing (if any)

There is no GUI way to change disk encryption password.

The solution you'd like

Add it to new Global Settings.

The value to a user, and who that user might be

People who prefer GUI tools (27% of our users, based on Survey) or like to use GUI tools not just CLI (65% of users).

@marmarta marmarta added T: enhancement P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Sep 10, 2022
@marmarta marmarta self-assigned this Sep 10, 2022
@andrewdavidwong andrewdavidwong added C: manager/widget cryptography This issue pertains to cryptography. labels Sep 11, 2022
@andrewdavidwong andrewdavidwong added this to the Release TBD milestone Sep 11, 2022
@andrewdavidwong andrewdavidwong added the ux User experience label Sep 11, 2022
@QUser534
Copy link

It would be great if this separately allowed deleting password slots, so multiple disk decryption passwords can exist at once. I usually keep my old password for a few weeks until I am sure the new password has been fully burned into my memory. I am probably not the only one.

@DemiMarie
Copy link

It would be great if this separately allowed deleting password slots, so multiple disk decryption passwords can exist at once. I usually keep my old password for a few weeks until I am sure the new password has been fully burned into my memory. I am probably not the only one.

Sadly this is not reliable on SSDs due to wear leveling.

@marmarek
Copy link
Member

Sadly this is not reliable on SSDs due to wear leveling.

Great majority of users (like, 99.9999% of them) don't need to be concerned about it (due to complexity of finding and extracting such data, and also due to a chance for it to be overridden by something else later). But if you are, you probably should wipe the whole disk when you change the passphrase even in the same slot.

In other words: this concern is out of scope for this tool.

@DemiMarie
Copy link

Sadly this is not reliable on SSDs due to wear leveling.

Great majority of users (like, 99.9999% of them) don't need to be concerned about it (due to complexity of finding and extracting such data, and also due to a chance for it to be overridden by something else later). But if you are, you probably should wipe the whole disk when you change the passphrase even in the same slot.

In other words: this concern is out of scope for this tool.

This is valid. We might be able to use the TPM to avoid it, but that can come later.

@jamke
Copy link

jamke commented Nov 14, 2022

Just a note - this feature is very well desired for other distros too.

I mean, maybe it's not a Qubes OS's task, because even in Kubuntu, that positions itself as user-friendly, people had to change and manage LVM passwords using terminal without GUI.

@andrewdavidwong andrewdavidwong removed this from the Release TBD milestone Aug 13, 2023
marmarek added a commit to QubesOS/qubes-builder that referenced this issue Nov 21, 2023
marmarek added a commit to QubesOS/qubes-builderv2 that referenced this issue Nov 21, 2023
@marmarek
Copy link
Member

https://github.com/QubesOS/qubes-disk-password-gui
It's very simple, but should be generic enough to use also outside of Qubes OS.

@andrewdavidwong andrewdavidwong added this to the Release 4.2 milestone Nov 21, 2023
marmarek added a commit to QubesOS/qubes-meta-packages that referenced this issue Nov 22, 2023
marmarek added a commit to QubesOS/qubes-builderv2 that referenced this issue Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: manager/widget cryptography This issue pertains to cryptography. P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. ux User experience
Projects
None yet
Development

No branches or pull requests

6 participants