Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement UI Notifications for cases of a Qube disk full #1872

Closed
bnvk opened this issue Mar 24, 2016 · 14 comments
Closed

Implement UI Notifications for cases of a Qube disk full #1872

bnvk opened this issue Mar 24, 2016 · 14 comments
Labels
C: core P: major Priority: major. Between "default" and "critical" in severity. release notes This issue should be mentioned in the release notes. ux User experience
Milestone

Comments

@bnvk
Copy link

bnvk commented Mar 24, 2016

Currently, one only realizes that a Qube is full usually after some other operation (downloading, installing) fails. We should surface notifications to users when a Qube is

  • 75% full
  • 85% full
  • 90% full

These should be system notifications that provide an actionable button that takes user to the Qubes Manager for that given Qube.

Additionally, there is the case where the sum total of "potential disk space allowed" for all Qubes, might be greater than that of the actual physical hard drive. In the case that this limit is actually reached @marmarek and @woju claim that all information about a users Qubes is erased. This of course is very bad for users and should be mitigated by not allowing a user to set each Qube to larger than total available space.

@andrewdavidwong andrewdavidwong added enhancement ux User experience labels Apr 6, 2016
@marmarek
Copy link
Member

Related to #1053

@marmarek marmarek modified the milestone: Far in the future Jun 21, 2016
@andrewdavidwong andrewdavidwong added C: core P: major Priority: major. Between "default" and "critical" in severity. labels Dec 23, 2017
@andrewdavidwong andrewdavidwong modified the milestones: Far in the future, Release 4.1 Dec 23, 2017
@tasket
Copy link

tasket commented Mar 21, 2018

This could be quickly done in 4.0 if its added to @marmarta 's disk space widget, or just made into a cron job or systemd timer.

I'll also suggest expanding this function beyond a warning:

Perhaps pausing domUs if the storage pool (containing admin root) free space goes below a certain number. It could even un-pause automatically once enough space has been freed. I don't know if Linux offers a better way to handle this (i.e. an LVM feature that can reserve space in a pool for a particular LV)... open to suggestions.

@marmarek
Copy link
Member

I don't know if Linux offers a better way to handle this (i.e. an LVM feature that can reserve space in a pool for a particular LV)... open to suggestions.

This is very similar to what we've discussed in #3226 (comment)

As for pausing qubes, this may be tricky. Imagine someone using USB keyboard, or just yubi key for screen unlock. Pausing sys-usb in that case would be bad...

@tasket
Copy link

tasket commented Mar 21, 2018

Probably could make an exception for sys-usb, which isn't expected to command a large private volume anyway.

@tasket
Copy link

tasket commented Mar 21, 2018

BTW, was referring to current arrangement with dom0 in thin pool in 3226, not allocating a static dom0 volume.

@tasket
Copy link

tasket commented Mar 27, 2018

Note: dom0 has dm-event.service which runs dmeventd. This supposedly monitors thin pools for the amount of space left and will log warnings (and even try to dismount member volumes) at certain percentage thresholds.

Monitoring this log output (via rsyslogd?) may be one way to implement notifications/pausing. But I still think using the widget is a good option, especially since it can be applied uniformly to the other storage types.

@marmarek
Copy link
Member

Notification + widget implemented as part of #3240

Safeguards against filling up pool where dom0 root lives would be much easier to implement in 4.1, where GUI will be moved out - no direct user interaction with dom0, can be much smaller, static volume.

@andrewdavidwong
Copy link
Member

Reopening due to #4404. Either there is more that needs to be implemented here, or it is not easily discoverable (UX issue).

@marmarek
Copy link
Member

Actual notifications (besides icon color change) are done in package in current-testing: QubesOS/updates-status#741

@andrewdavidwong
Copy link
Member

Actual notifications (besides icon color change) are done in package in current-testing: QubesOS/updates-status#741

FYI @brendanhoar. Please consider helping us test this, if you can.

@brendanhoar
Copy link

brendanhoar commented Apr 17, 2019

It wasn't clear to me from the thread, and it might only be because I'm thick headed...but I will ask specifically:

Is the idea of having dom0 (and perhaps management/GUI VMs) be located in a separate LVM pool ("system" LVM pool) than most of the other VMs ("user" LVM pool) being considered?

I think that makes it less likely that dom0 will fail to start up and gives users additional recovery flexibility if there are issues with the "user" LVM pool. Proper log rotation, etc. would of course be key in dom0 to keep it semi-clean and below a certain %age of the "system" LVM pool...

Brendan

@brendanhoar
Copy link

Update: it appears that 4.1 will use two pools by default: one (smaller) pool for dom0 use, one (larger) pool for all VMs.

This means that if the VM-containing pool has issues, dom0 may still be booted and utilized to fix the VM pool. Esp. if #5820 is addressed. :)

marmarta added a commit to marmarta/qubes-desktop-linux-manager that referenced this issue May 28, 2020
The qui-disk-space widget will now show notifications when a VM's
storage space is close to running out. Also information about this
will be displayed in the widget menu itself.

references QubesOS/qubes-issues#1872
@marmarta
Copy link
Member

So, notifications for lvm pools being close to full are implemented already, I've just pushed a commit that will also notify about VM volumes being close to full. Is there anything else we should do here?

@andrewdavidwong
Copy link
Member

Looks good to me, @marmarta. If anyone feels that more should be done here, please leave a comment.

marmarta added a commit to marmarta/qubes-desktop-linux-manager that referenced this issue Jun 3, 2020
The qui-disk-space widget will now show notifications when a VM's
storage space is close to running out. Also information about this
will be displayed in the widget menu itself.

references QubesOS/qubes-issues#1872
@marmarek marmarek added the release notes This issue should be mentioned in the release notes. label Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: core P: major Priority: major. Between "default" and "critical" in severity. release notes This issue should be mentioned in the release notes. ux User experience
Projects
None yet
Development

No branches or pull requests

6 participants