Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve default SVD rrule_alg #79

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

pbrehmer
Copy link
Collaborator

This PR will change the default SVD cotangent problem rrule_alg to Arnoldi.

After some benchmarking, Arnoldi has turned out to be the fastest algorithm in many cases (as compared to GMRES and BiCGStab). The Krylov dimension has to be chosen according to the chosen environment dimension, so this has to be adapted to the specific problems anyway; but choosing a reasonably large dimension will ensure less warnings and better convergence, usually. To really get rid of the warnings by default (since they turn out to be non-crucial in most cases), I set verbosity=-1.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/PEPSKit.jl 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

@pbrehmer pbrehmer requested a review from lkdvos October 25, 2024 07:57
@pbrehmer pbrehmer merged commit a17f7b7 into master Oct 25, 2024
9 checks passed
@pbrehmer pbrehmer deleted the pb-improve-default-svdrrule branch October 25, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants