Improve default SVD rrule_alg
#79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
lkdvos
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will change the default SVD cotangent problem
rrule_algtoArnoldi.After some benchmarking,
Arnoldihas turned out to be the fastest algorithm in many cases (as compared toGMRESandBiCGStab). The Krylov dimension has to be chosen according to the chosen environment dimension, so this has to be adapted to the specific problems anyway; but choosing a reasonably large dimension will ensure less warnings and better convergence, usually. To really get rid of the warnings by default (since they turn out to be non-crucial in most cases), I setverbosity=-1.