You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems that on the newest version KrylovKit something broke: If we compute the fixed-point gradient fpgrad using KrylovKit.GMRES and it doesn't converge, I get the following conversion error:
It turns out that this only happens on the newest version v0.7.1, whereas on the previous version v0.6.1 this was not a problem. For comparison, I currently use the following package versions:
Note that I added the master branch of MPSKit to resolve the KrylovKit dependency conflict. Here's a MWE that should reproduce the error where I intentionally prevent the linear solver from converging:
using Random
using PEPSKit
using TensorKit
using Zygote
using KrylovKit
Random.seed!(42039482038)
χbond =2
χenv =8
boundary_alg =CTMRG(;
trscheme=truncdim(χenv), tol=1e-10, miniter=20, maxiter=100, verbosity=1
)
psi =InfinitePEPS(2, χbond)
env =leading_boundary(CTMRGEnv(psi; Venv=ℂ^χenv), psi, boundary_alg)
functioncompute_grad(peps, envs, boundary_alg, alg_rrule)
E, g = Zygote.withgradient(peps) do psi
envs2 = PEPSKit.hook_pullback(leading_boundary, envs, psi, boundary_alg; alg_rrule)
returncostfun(psi, envs2, H)
endreturnonly(g)
end
g =compute_grad(psi, env, boundary_alg, KrylovKit.GMRES(; tol=1e-16, maxiter=2, verbosity=3))
I am not sure why this only ever happened when it does not converge, but this fix seems to at least solve the minimal example you added (thanks for that by the way, that made solving this so much easier!)
It seems that on the newest version KrylovKit something broke: If we compute the fixed-point gradient
fpgrad
using KrylovKit.GMRES and it doesn't converge, I get the following conversion error:It turns out that this only happens on the newest version v0.7.1, whereas on the previous version v0.6.1 this was not a problem. For comparison, I currently use the following package versions:
Note that I added the master branch of MPSKit to resolve the KrylovKit dependency conflict. Here's a MWE that should reproduce the error where I intentionally prevent the linear solver from converging:
Maybe @lkdvos knows what's going on here?
The text was updated successfully, but these errors were encountered: