Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TensorKit's tsvd! reverse-rule for :fixed differentiation mode #150

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pbrehmer
Copy link
Collaborator

@pbrehmer pbrehmer commented Mar 7, 2025

Here we adapt tsvd! and FixedSVD such that the :fixed differentiation mode can also use TensorKit's SVD adjoint. For context, the TensorKit.tsvd! reverse-rule requires the full, untruncated SVD which is currently not passed along the CTMRG algorithm. To change this, tsvd! needs to return the untruncated decomposition as well. Hopefully, TensorKit's reverse-rule will eliminate some of the instabilities of KrylovKit's SVD reverse-rule.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 54 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/utility/svd.jl 0.00% 46 Missing ⚠️
src/algorithms/ctmrg/projectors.jl 0.00% 4 Missing ⚠️
src/algorithms/ctmrg/simultaneous.jl 0.00% 4 Missing ⚠️
Files with missing lines Coverage Δ
...rithms/optimization/fixed_point_differentiation.jl 3.19% <ø> (-91.71%) ⬇️
src/algorithms/ctmrg/projectors.jl 8.57% <0.00%> (-86.89%) ⬇️
src/algorithms/ctmrg/simultaneous.jl 1.72% <0.00%> (-96.46%) ⬇️
src/utility/svd.jl 1.86% <0.00%> (-84.05%) ⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant