convert

MatthiasSchmidtblaicherQC · MatthiasSchmidtblaicherQC · commit 8504c0355c2f · 2024-01-30T18:08:54.000+01:00
diff --git a/src/glum/_glm.py b/src/glum/_glm.py
@@ -896,7 +896,7 @@ def _convert_from_pandas(
                 ),
                 getattr(self, "cat_missing_method", "fail"),
             )
-            if getattr(self, "cat_missing_method", "fail"):
+            if getattr(self, "cat_missing_method", "fail") == "convert":
                 df = _add_missing_categories(
                     df=df,
                     dtypes=self.feature_dtypes_,

Original file line number	Diff line number	Diff line change
`@@ -896,7 +896,7 @@ def _convert_from_pandas(`
`896`	`896`	`),`
`897`	`897`	`getattr(self, "cat_missing_method", "fail"),`
`898`	`898`	`)`
`899`		`- if getattr(self, "cat_missing_method", "fail"):`
	`899`	`+ if getattr(self, "cat_missing_method", "fail") == "convert":`
`900`	`900`	`df = _add_missing_categories(`
`901`	`901`	`df=df,`
`902`	`902`	`dtypes=self.feature_dtypes_,`