We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The NumPy code does not adhere to PEP8 and the class could easily be removed, so that compute_gap is just a function of the different parameters.
compute_gap
Then we could get rid of all the separate functions in the code block that starts with
# ϕ_R def ϕ_R(mc, R_new): mc_new = equalizing_diff(R_new, mc.T, mc.γ_h, mc.γ_c, mc.w_h0, mc.D, mc.π) return mc_new.compute_gap() ϕ_R = np.vectorize(ϕ_R)
@thomassargent30 Would you be willing to let @HumphreyYang and I simplify the NumPy part of the code without changing what it does?
The text was updated successfully, but these errors were encountered:
The benchmark parameters
# set benchmark parameters R = 1.05 T = 40 γ_h, γ_c = 1.01, 1.01 w_h0 = 1 D = 10
could be included at default values for the compute_gap function.
Sorry, something went wrong.
Hi @jstac,
I think this issue has been addressed in #388. Would you like me to close it?
Thanks @HumphreyYang, closing.
No branches or pull requests
The NumPy code does not adhere to PEP8 and the class could easily be removed, so that
compute_gap
is just a function of the different parameters.Then we could get rid of all the separate functions in the code block that starts with
@thomassargent30 Would you be willing to let @HumphreyYang and I simplify the NumPy part of the code without changing what it does?
The text was updated successfully, but these errors were encountered: