Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in DateChangeTimeKeeper #8470

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Marinovsky
Copy link
Collaborator

Description

Sometimes, when the security exchange timezone is not the same as the data timezone, the class DateChangeTimeKeeper does not produce a delisting event but the SubscriptionDataReader thinks one was produced. Apparently, this happens since in DateChangeTimeKeeper the date returned by _tradableDatesInDataTimeZone is compared with the delisting date after converting it to the exchange timezone. However, in SubscriptionDataReader, that same date is directly compared with the delisting date.

Related Issue

Closes #8413

Motivation and Context

With this change all index option contracts will be exercised after being delisted

Requires Documentation Change

N/A

How Has This Been Tested?

In progress...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expired Index Option Contracts Aren't Always Exercised
2 participants